You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2016/10/18 12:55:58 UTC
[jira] [Updated] (THRIFT-3916) Errors thrown from JavaScript client
is strings and not errors
[ https://issues.apache.org/jira/browse/THRIFT-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James E. King, III updated THRIFT-3916:
---------------------------------------
Priority: Minor (was: Major)
> Errors thrown from JavaScript client is strings and not errors
> --------------------------------------------------------------
>
> Key: THRIFT-3916
> URL: https://issues.apache.org/jira/browse/THRIFT-3916
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Reporter: Simen Bekkhus
> Priority: Minor
> Labels: javascript
>
> In JavaScript, you can {{throw}} any object, including strings, but to get stack traces one should throw {{Errors}}.
> The generated JS code throws the error string directly, instead of wrapping it in {{new Error}}.
> Node core _only_ rejects with/throws Errors, never strings, and Thrift should follow the same standard.
> https://nodejs.org/api/errors.html#errors_class_error
> {quote}
> All errors generated by Node.js, including all System and JavaScript errors, will either be instances of, or inherit from, the Error class.
> {quote}
> PR for the change [here|https://github.com/apache/thrift/pull/1075].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)