You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/06/28 07:59:52 UTC
[GitHub] zeppelin pull request #1099: ZEPPELIN-1071 ] Ace-editor hidden auto-complete...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1099
ZEPPELIN-1071 ] Ace-editor hidden auto-complete additional events.
### What is this PR for?
Does not hide popup for Ace editor-autocomplete
If the page move or click on an event occurs, the auto-completion should be hidden.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1071
### How should this be tested?
1. Call the auto-complete in the code window (ctrl + shift + space)
2. Click anywhere without closing the pop-up.
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin fix/acecomplete_hide
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1099.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1099
----
commit af8a16ef92ff271885e1c26cb55d56ca00cc38d0
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-28T07:50:04Z
Ace-editor hidden auto-complete additional events.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1099: ZEPPELIN-1071 ] Ace-editor hidden auto-complete additi...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1099
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1099: ZEPPELIN-1071 ] Ace-editor hidden auto-complete...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1099
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1099: ZEPPELIN-1071 ] Ace-editor hidden auto-complete additi...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1099
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---