[GitHub] jena issue #188: JENA-1197 return exit code 1 when there is a problem valida...

[afs <gi...@git.apache.org>]

Github user afs commented on the issue:

    https://github.com/apache/jena/pull/188
  
    That looks OK for one file.  What to do about multiple files on the command line is trickier - that is, there are reasonable use cases for different behaviors.
    
    The call stack is (deepest first):
    
    {noformat}
    parseRIOT(String, String, TypedInputStream) : void - riotcmd.CmdLangParse
    parseFile(String, String, TypedInputStream) : void - riotcmd.CmdLangParse
    parseFile(String) : void - riotcmd.CmdLangParse
    exec$() : void - riotcmd.CmdLangParse
    exec() : void - riotcmd.CmdLangParse
    {noformat}
    
    where the multiple file loop is in `exec$()`. I wonder if the "parse*" ought to return true/false (or throw a custom exception) as to whether they succeeded or not and the decision of whether and when to exit is made in `exec$` (just before the `postParse` step). Then an attempt to parse all the files happens and then `exit(1)` if any are broken.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---