You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/01 18:06:04 UTC

[GitHub] [arrow] jonkeane opened a new pull request #10430: ARROW-12915 [Release] Build of ubuntu-docs is failing on thrift

jonkeane opened a new pull request #10430:
URL: https://github.com/apache/arrow/pull/10430


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jonkeane commented on pull request #10430: ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift

Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10430:
URL: https://github.com/apache/arrow/pull/10430#issuecomment-852480193


   I ran this on crossbow (locally since the GH actions comment bot isn't working right now https://issues.apache.org/jira/browse/ARROW-12919) and the only ubuntu crossbow builds that failed were all ones that have other current nightly failures.
   
   I've also added a defaults docs nightly to catch if we have a mismatch like this in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jonkeane commented on a change in pull request #10430: ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10430:
URL: https://github.com/apache/arrow/pull/10430#discussion_r643569671



##########
File path: ci/docker/ubuntu-20.04-cpp.dockerfile
##########
@@ -75,6 +75,7 @@ RUN apt-get update -y -q && \
         libcurl4-openssl-dev \
         libgflags-dev \
         libgoogle-glog-dev \
+        libgrpc++-dev \

Review comment:
       Ah yes, thanks for that! Cruft leftover from me trying to get it working




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10430: ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10430:
URL: https://github.com/apache/arrow/pull/10430#issuecomment-852347573


   https://issues.apache.org/jira/browse/ARROW-12915


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on a change in pull request #10430: ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10430:
URL: https://github.com/apache/arrow/pull/10430#discussion_r643565782



##########
File path: ci/docker/ubuntu-20.04-cpp.dockerfile
##########
@@ -75,6 +75,7 @@ RUN apt-get update -y -q && \
         libcurl4-openssl-dev \
         libgflags-dev \
         libgoogle-glog-dev \
+        libgrpc++-dev \

Review comment:
       We don't need to install `libgrpc++-dev` and `protobuf-compiler-grpc` when we use bundled gRPC and ProtoBuf.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jonkeane commented on pull request #10430: ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift

Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10430:
URL: https://github.com/apache/arrow/pull/10430#issuecomment-852340642


   This PR resolves building on Ubuntu 20.04 [which is our default](https://github.com/apache/arrow/blob/master/.env#L45) though the crossbow build in tasks is [on 20.10](https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L949) which has one of these additions, but also a newer protobuff so that's not needed to be bundled. 
   
   We also might consider _not_ adding these lines but making clear in the docker compose file that `ubuntu-docs` will not work with Ubuntu 20.04 and instead should always be build on 20.10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jonkeane closed pull request #10430: ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift

Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #10430:
URL: https://github.com/apache/arrow/pull/10430


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org