You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "tanclary (via GitHub)" <gi...@apache.org> on 2023/06/07 21:33:14 UTC

[GitHub] [calcite] tanclary commented on pull request #3234: [CALCITE-5735] Add SAFE_MULTIPLY function (enabled in BigQuery)

tanclary commented on PR #3234:
URL: https://github.com/apache/calcite/pull/3234#issuecomment-1581540592

   @zoudan  I have amended my commit, if you would like to take a look. I added more robust support for all of the possible operand combinations, and I adjusted how I check for overflow as well. Feel free to leave any comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org