You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2015/02/17 14:03:04 UTC

wicket git commit: Refactoring for InlineEnclosure and Enclosure to remove legacy code (see WICKET-5835)

Repository: wicket
Updated Branches:
  refs/heads/master c97e3f4b0 -> 3693d070b


Refactoring for InlineEnclosure and Enclosure to remove legacy code (see WICKET-5835)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/3693d070
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/3693d070
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/3693d070

Branch: refs/heads/master
Commit: 3693d070bd824a791bcdc2a69e7f8c0fea408f38
Parents: c97e3f4
Author: Andrea Del Bene <ad...@apache.org>
Authored: Tue Feb 17 14:02:23 2015 +0100
Committer: Andrea Del Bene <ad...@apache.org>
Committed: Tue Feb 17 14:02:23 2015 +0100

----------------------------------------------------------------------
 .../wicket/markup/html/internal/InlineEnclosure.java    | 12 ------------
 .../wicket/protocol/http/AjaxEnclosureListener.java     |  1 -
 2 files changed, 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/3693d070/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
index 55dc3b5..e5d8638 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
@@ -59,16 +59,4 @@ public class InlineEnclosure extends Enclosure
 
 		super.onComponentTag(tag);
 	}
-
-	/**
-	 * Update the visibility of this In-line enclosure with that of the controlling child.
-	 * 
-	 * @return the new visibility setting.
-	 */
-	public boolean updateVisibility()
-	{
-		boolean visible = getChild().determineVisibility();
-		setVisible(visible);
-		return visible;
-	}
 }

http://git-wip-us.apache.org/repos/asf/wicket/blob/3693d070/wicket-core/src/main/java/org/apache/wicket/protocol/http/AjaxEnclosureListener.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AjaxEnclosureListener.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AjaxEnclosureListener.java
index 196e35d..5e6c0c0 100644
--- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AjaxEnclosureListener.java
+++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AjaxEnclosureListener.java
@@ -85,7 +85,6 @@ public class AjaxEnclosureListener extends AjaxRequestTarget.AbstractListener
 					Component component = entry.getValue();
 					if (isControllerOfEnclosure(component, enclosure))
 					{
-						enclosure.updateVisibility();
 						target.add(enclosure);
 						visit.dontGoDeeper();
 						keysToRemove.add(componentId);