You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by ivakegg <gi...@git.apache.org> on 2016/11/04 19:06:42 UTC

[GitHub] accumulo pull request #179: ACCUMULO-4502 Added volative to some class membe...

GitHub user ivakegg opened a pull request:

    https://github.com/apache/accumulo/pull/179

    ACCUMULO-4502 Added volative to some class members to mitigate issues\u2026

    \u2026 when one thread seeks the iterator, and another thread is reading it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ivakegg/accumulo ACCUMULO-4502

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #179
    
----
commit 513c78b5c04e8a2a0584aaec57b7e51c280a15c3
Author: Ivan N Bella <in...@canx2ul-97681x.infosec.tycho.ncsc.mil>
Date:   2016-11-04T19:02:55Z

    ACCUMULO-4502 Added volative to some class members to mitigate issues when one thread seeks the iterator, and another thread is reading it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo issue #179: ACCUMULO-4502 Added volative to some class members to m...

Posted by ivakegg <gi...@git.apache.org>.
Github user ivakegg commented on the issue:

    https://github.com/apache/accumulo/pull/179
  
    After an exhaustive search through this code, the only reason I can come up with is an issue with a member reference in the underlying HeapIterator.  The scenario would be as follows:
    
    thread 1: calls hasTop() which is invoked on then in memory data source
    thread 2: calls switchSource which sets up the new datasource and calls seek which results in topIdx being set
    thread1: calls next() which gets a value of null for topIdx
    
    So if topIdx is marked as volatile then this should not happen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request #179: ACCUMULO-4502 Added volative to some class membe...

Posted by ivakegg <gi...@git.apache.org>.
Github user ivakegg closed the pull request at:

    https://github.com/apache/accumulo/pull/179


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---