[jira] [Commented] (BEAM-1726) TestFlinkRunner should assert PAssert success/failure counters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929810#comment-15929810 ] 

ASF GitHub Bot commented on BEAM-1726:
--------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/beam/pull/2263

    [BEAM-1726] TestFlinkRunner should assert PAssert success/failure counters

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/beam flink-test-runner-aggregators

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2263
    
----
commit 354bbcc2d87164cd5bb94b7c71d50df1d4c17c93
Author: Aviem Zur <av...@gmail.com>
Date:   2017-03-17T11:36:55Z

    [BEAM-1726] TestFlinkRunner should assert PAssert success/failure counters

----


> TestFlinkRunner should assert PAssert success/failure counters
> --------------------------------------------------------------
>
>                 Key: BEAM-1726
>                 URL: https://issues.apache.org/jira/browse/BEAM-1726
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>            Reporter: Aviem Zur
>            Assignee: Aviem Zur
>
> {{TestFlinkRunner}} should assert the value of {{PAssert}}'s success/failure aggregators. i.e. assert that:
> {code}
> <PAssert.SUCCESS_COUNTER value> == [number of assertions defined in  the pipeline]
> &&
> <PAssert.FAILURE_COUNTER value> == 0
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)