You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/06 18:29:46 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #8781: [css] WiP: Bringing Bootswatch in line with external variables

rusackas opened a new pull request #8781: [css] WiP: Bringing Bootswatch in line with external variables
URL: https://github.com/apache/incubator-superset/pull/8781
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [X] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Bootstap and Bootswatch (Cosmo theme) have a bunch of colors and things in them that have not yet been brought inline with the global styles. This PR will aim to address that. Many colors (e.g warning/error) had values on both sides of the fence, so some compromises will be made. I'll try to add relevant screencaps below of the highlights of those compromises.
   
   I'll be making additional changes/commits, but thought I should put this in the open for now.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   TK
   
   ### ADDITIONAL INFORMATION
   - [x] Changes UI
   
   ### REVIEWERS
   TK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org