You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/17 08:14:40 UTC
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#835: HDDS-3399. Update JaegerTracing
adoroszlai commented on a change in pull request #835: HDDS-3399. Update JaegerTracing
URL: https://github.com/apache/hadoop-ozone/pull/835#discussion_r410056923
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java
##########
@@ -129,8 +132,53 @@ private static SpanContext extractParent(String parent, Tracer tracer) {
private static boolean isTracingEnabled(
org.apache.hadoop.conf.Configuration conf) {
return conf.getBoolean(
- ScmConfigKeys.HDDS_TRACING_ENABLED,
- ScmConfigKeys.HDDS_TRACING_ENABLED_DEFAULT);
+ ScmConfigKeys.HDDS_TRACING_ENABLED,
+ ScmConfigKeys.HDDS_TRACING_ENABLED_DEFAULT);
+ }
+
+ /**
+ * Execute a new function inside an activated span.
+ */
+ public static <R> R executeInsideNewSpan(String spanName,
Review comment:
Nit: can we simplify to `executeInNewSpan`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org