You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/08 23:01:01 UTC
[jira] [Commented] (CLIMATE-642) Improper unit set in
water_flux_unit_conversion
[ https://issues.apache.org/jira/browse/CLIMATE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577842#comment-14577842 ]
ASF GitHub Bot commented on CLIMATE-642:
----------------------------------------
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/207
CLIMATE-642 - Fix improper unit set in water_flux_unit_conversion
- removed 'swe' conversion to SI units (km) as this is neither common nor CF convention
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE-642
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit 4b73b3164eb79195c9b1454da37a2b61099a1eb7
Author: Kim Whitehall <ki...@jpl.nasa.gov>
Date: 2015-06-08T20:59:00Z
CLIMATE-642 - Fix improper unit set in water_flux_unit_conversion
- removed 'swe' conversion to SI units (km) as this is neither
common or CF convention
----
> Improper unit set in water_flux_unit_conversion
> -----------------------------------------------
>
> Key: CLIMATE-642
> URL: https://issues.apache.org/jira/browse/CLIMATE-642
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: regridding/data processing
> Affects Versions: 0.5
> Reporter: Michael Joyce
> Assignee: Kim Whitehall
> Priority: Minor
> Fix For: 1.0.0
>
>
> Jinwon mentioned that it looked like some units were set improperly in the water_flux_unit_conversion dataset processor function. Seems to be here where the problem is:
> https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L370
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)