[GitHub] rawlinp commented on a change in pull request #2858: Prohibit content invalidation requests for no-origin DS types

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #2858: Prohibit content invalidation requests for no-origin DS types
URL: https://github.com/apache/trafficcontrol/pull/2858#discussion_r219634207
 
 

 ##########
 File path: traffic_ops/app/lib/API/Job.pm
 ##########
 @@ -168,6 +168,10 @@ sub create_current_user_job {
 	if ( !defined($ds) ) {
 		return $self->not_found();
 	}
+	my $org_server_fqdn = UI::DeliveryService::compute_org_server_fqdn($self, $ds_id);
+	if ( !defined($org_server_fqdn) ) {
 
 Review comment:
   The `compute_org_server_fqdn` function will never return an empty string, only `undef` or a valid-looking `orgServerFqdn` string built from the DS's primary origin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services