You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xbean-dev@geronimo.apache.org by "Ingo Bormann (JIRA)" <ji...@apache.org> on 2008/08/01 18:16:32 UTC
[jira] Created: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
------------------------------------------------------------------------------------------------
Key: XBEAN-109
URL: https://issues.apache.org/jira/browse/XBEAN-109
Project: XBean
Issue Type: Bug
Components: classloader
Environment: jdk1.6, Windows 2000 Latest version from SVN
Reporter: Ingo Bormann
A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Posted by "Benjamin Bentmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639377#action_12639377 ]
Benjamin Bentmann commented on XBEAN-109:
-----------------------------------------
+1 on the usage of {{File.toURI().toURL()}}
-1 on the replacement of {{new File(url.toURI())}} with {{new File(url.getPath())}}. {{URL.getPath()}} merely returns a substring of the URL and as such can still contain percent-encoded characters. Therefore, {{new File(url.getPath())}} should only be used as a fallback in case the URISyntaxException indicates an unescaped URL.
> org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
> ------------------------------------------------------------------------------------------------
>
> Key: XBEAN-109
> URL: https://issues.apache.org/jira/browse/XBEAN-109
> Project: XBean
> Issue Type: Bug
> Components: classloader
> Environment: jdk1.6, Windows 2000 Latest version from SVN
> Reporter: Ingo Bormann
> Attachments: xbean.diff
>
>
> A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
> I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed XBEAN-109.
------------------------------
Resolution: Fixed
Fix Version/s: 3.6
I think we are just closing issues once they are fixed. Ideally we would make the jira options the same as the geronimo ones.
> org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
> ------------------------------------------------------------------------------------------------
>
> Key: XBEAN-109
> URL: https://issues.apache.org/jira/browse/XBEAN-109
> Project: XBean
> Issue Type: Bug
> Components: classloader
> Environment: jdk1.6, Windows 2000 Latest version from SVN
> Reporter: Ingo Bormann
> Assignee: Ivan
> Fix For: 3.6
>
> Attachments: xbean.diff
>
>
> A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
> I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Posted by "Ingo Bormann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ingo Bormann updated XBEAN-109:
-------------------------------
Attachment: xbean.diff
This is a diff between the head of SVN and my modified version. You will find that File.toURL() is replaced by File.toURI().toURL() in a couple of places. Should not be too hard to apply.
> org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
> ------------------------------------------------------------------------------------------------
>
> Key: XBEAN-109
> URL: https://issues.apache.org/jira/browse/XBEAN-109
> Project: XBean
> Issue Type: Bug
> Components: classloader
> Environment: jdk1.6, Windows 2000 Latest version from SVN
> Reporter: Ingo Bormann
> Attachments: xbean.diff
>
>
> A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
> I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Posted by "Benjamin Bentmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639377#action_12639377 ]
bentmann edited comment on XBEAN-109 at 10/14/08 4:04 AM:
-------------------------------------------------------------------
+1 on the usage of {{File.toURI().toURL()}}
As for the replacement of {{new File(url.getPath())}} with {{new File(url.toURI())}}: It might be wise to simply move the call {{new File(url.getPath())}} into the catch for the URISyntaxException. This would increase robustness for the case where the input URL is not properly escaped.
was (Author: bentmann):
+1 on the usage of {{File.toURI().toURL()}}
-1 on the replacement of {{new File(url.toURI())}} with {{new File(url.getPath())}}. {{URL.getPath()}} merely returns a substring of the URL and as such can still contain percent-encoded characters. Therefore, {{new File(url.getPath())}} should only be used as a fallback in case the URISyntaxException indicates an unescaped URL.
> org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
> ------------------------------------------------------------------------------------------------
>
> Key: XBEAN-109
> URL: https://issues.apache.org/jira/browse/XBEAN-109
> Project: XBean
> Issue Type: Bug
> Components: classloader
> Environment: jdk1.6, Windows 2000 Latest version from SVN
> Reporter: Ingo Bormann
> Attachments: xbean.diff
>
>
> A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
> I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711152#action_12711152 ]
Ivan commented on XBEAN-109:
----------------------------
Merge the patch to XBean trunk at rev 776705. Thanks Ingo Bormann for the patch !
> org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
> ------------------------------------------------------------------------------------------------
>
> Key: XBEAN-109
> URL: https://issues.apache.org/jira/browse/XBEAN-109
> Project: XBean
> Issue Type: Bug
> Components: classloader
> Environment: jdk1.6, Windows 2000 Latest version from SVN
> Reporter: Ingo Bormann
> Assignee: Ivan
> Attachments: xbean.diff
>
>
> A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
> I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan reassigned XBEAN-109:
--------------------------
Assignee: Ivan
> org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
> ------------------------------------------------------------------------------------------------
>
> Key: XBEAN-109
> URL: https://issues.apache.org/jira/browse/XBEAN-109
> Project: XBean
> Issue Type: Bug
> Components: classloader
> Environment: jdk1.6, Windows 2000 Latest version from SVN
> Reporter: Ingo Bormann
> Assignee: Ivan
> Attachments: xbean.diff
>
>
> A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
> I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (XBEAN-109) org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
Posted by David Jencks <da...@yahoo.com>.
On May 20, 2009, at 7:18 AM, Ivan (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711154
> #action_12711154 ]
>
> Ivan commented on XBEAN-109:
> ----------------------------
>
> Hi, just find that for XBean JIRAs, there is no "resolve" action. So
> for these JIRAs, shall I need to start a RTC view, then commit the
> patch files ?
no, just close the issue.
If you can figure out how to get the workflow to be the same as in
geronimo, even better.
thanks
david jencks
>
>
>> org.apache.xbean.classloader.JarFileClassLoader can not handle
>> pathnames with containing spaces
>> ------------------------------------------------------------------------------------------------
>>
>> Key: XBEAN-109
>> URL: https://issues.apache.org/jira/browse/XBEAN-109
>> Project: XBean
>> Issue Type: Bug
>> Components: classloader
>> Environment: jdk1.6, Windows 2000 Latest version from SVN
>> Reporter: Ingo Bormann
>> Assignee: Ivan
>> Attachments: xbean.diff
>>
>>
>> A lot of classes in the package org.apache.xbean.classloader use
>> File.toURL() instead of File.toURI().toURL(). File.toURL() is
>> deprecated and does not work on windows with pathnames containing
>> spaces. If a pathname contains spaces then File.toURL() does not
>> convert spaces correctly. Javadoc recommends to use
>> File.toURI().toURL() instead.
>> I have a patched version where this is fixed for the full package
>> org.apache.xbean.classloader.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (XBEAN-109)
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711154#action_12711154 ]
Ivan commented on XBEAN-109:
----------------------------
Hi, just find that for XBean JIRAs, there is no "resolve" action. So for these JIRAs, shall I need to start a RTC view, then commit the patch files ?
> org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
> ------------------------------------------------------------------------------------------------
>
> Key: XBEAN-109
> URL: https://issues.apache.org/jira/browse/XBEAN-109
> Project: XBean
> Issue Type: Bug
> Components: classloader
> Environment: jdk1.6, Windows 2000 Latest version from SVN
> Reporter: Ingo Bormann
> Assignee: Ivan
> Attachments: xbean.diff
>
>
> A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.
> I have a patched version where this is fixed for the full package org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.