[GitHub] [druid] senthilkv commented on a change in pull request #10495: Added Request log updates for status change on cooridnator / overlord…

[GitBox <gi...@apache.org>]

senthilkv commented on a change in pull request #10495:
URL: https://github.com/apache/druid/pull/10495#discussion_r506581560



##########
File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyRequestLog.java
##########
@@ -41,6 +45,20 @@ public void log(Request request, Response response)
           request.getHttpURI().toString(),
           request.getProtocol()
       );
+    } else if ((HttpMethod.POST.equals(request.getMethod())

Review comment:
       Hi @gianm  Thanks for taking a looking into my PR.  I completely agree with you when the debug enabled , new portion will not get executed.  Normally in production cluster the debug mode may not have been enabled, The intent of the change is to identify the state change of the data such as Insert, Update, Delete (Also why, what, when)  on the data so that it can help debug and correlate issues related to data, configuration changes etc. 
   
   The intention of adding user was to identify which user but it may not be required and I can set it only the elements as in debug mode.  This way we can maintain uniformity and backward compatibility to avoid any log parsing issues due to this change.  Please let me know what is your opinion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org