You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/12 08:52:04 UTC
[jira] [Commented] (GEODE-269) Remove deprecated methods on
FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007815#comment-16007815 ]
ASF GitHub Bot commented on GEODE-269:
--------------------------------------
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/511
Feature/geode 269
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Yes. JIRA reference is GEODE-269.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
Yes.
- [ ] Is your initial contribution a single, squashed commit?
No. It is multiple commit, one actual code change and other is resolving conflict with latest develop
- [ ] Does `gradlew build` run cleanly?
Yes
- [ ] Have you written or updated unit tests to verify your changes?
Updated unit tests
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
Not adding dependencies.
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-269
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #511
----
commit e2f337a23303822f8cd28bc887afca7203759673
Author: Deepak Dixit <de...@gmail.com>
Date: 2017-05-10T16:52:03Z
GEODE-269 : Removing deprecated API's from FunctionService.
commit 929687e28335ee5ace679be5c540857080afd48f
Author: Deepak Dixit <de...@gmail.com>
Date: 2017-05-12T08:33:39Z
GEODE-269 : Resolving conflicts with develop.
commit 3054de42d38aa8bfadd8912f0ab4dde259a701ef
Author: Deepak Dixit <de...@gmail.com>
Date: 2017-05-12T08:38:21Z
GEODE-269 : Resolving conflicts with develop.
----
> Remove deprecated methods on FunctionService
> --------------------------------------------
>
> Key: GEODE-269
> URL: https://issues.apache.org/jira/browse/GEODE-269
> Project: Geode
> Issue Type: Sub-task
> Reporter: Darrel Schneider
> Assignee: Deepak Dixit
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> FunctionService has a three deprecated methods that should be easy to remove. All the deprecated methods have a DistributedSystem parameter. New flavors of these methods exist that do not take the DistributedSystem since it is known implicitly by the FunctionService.
> Many tests use the deprecated methods but it should be easy to change them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)