You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/11 13:42:01 UTC
[PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
borinquenkid opened a new pull request, #16604:
URL: https://github.com/apache/grails-core/pull/16604
## What
Converts the remaining Java sources of `grails-web-gsp`, `grails-web-mvc`, `grails-web-core` to Groovy: 23 `.java` files removed, 29 `.groovy` files added (37 files changed, 2776 insertions(+), 2060 deletions(-)).
## Why
The maintainers asked on #16351 for the Java-to-Groovy migration to land one Gradle project at a time as a stack of PRs, bottom-up in dependency order. #16572 did `grails-data-hibernate7`; this PR is 22 of 30 in the next stack (base: `refactor/java-to-groovy-grails-web-url-mappings`). The end state of every file is taken from the `9.0.x-java-to-groovy` branch, which already carries the regression fixes found by CI.
Commits:
- 07c4880c8b refactor: convert grails-web-core to Groovy
- d930311f1a refactor: convert grails-web-mvc to Groovy
- dfd7772ca4 refactor: convert grails-web-gsp to Groovy
## Changed outside the converted sources
- `M grails-web-core/build.gradle`
## Java-facing API sweep
Every deleted `.java` was compared with its Groovy twin via `javap -v -protected` (class declaration, public/protected fields, constructors, methods incl. modifiers/throws/generics, interface default methods, nested class modifiers, and the annotations callers see). Result:
- `grails-web-gsp`: 8 deleted .java, 0 differences requiring action
- `grails-web-mvc`: 7 deleted .java, 0 differences requiring action
- `grails-web-core`: 8 deleted .java, 0 differences requiring action
See also the notes below. Remaining informational entries (widened visibility, e.g. Groovy property accessors): 8.
## Verification
- `classes` and `testClasses` (plus `ast`/`cli`/`testFixtures` source sets where present) of the converted project(s) and of their direct dependents compile: ['grails-async', 'grails-codecs', 'grails-controllers', 'grails-databinding', 'grails-gsp', 'grails-i18n', 'grails-mimetypes', 'grails-rest-transforms', 'grails-scaffolding', 'grails-sitemesh3', 'grails-test-core', 'grails-test-suite-base', 'grails-url-mappings', 'grails-validation', 'grails-web-jsp']
- No test suites were run locally (the umbrella branch was verified; CI runs them). `codeStyle`, `rat` and a whole-repo `build -PskipTests` are run once on the tip of the stack.
## Notes
- Informational sweep entries that are not regressions: Groovy enums gain `MIN_VALUE`/`MAX_VALUE`/`next()`/`previous()`, property accessors appear for formerly package-private members, nested static classes with implicit constructors become public (they were `protected`), and generic type parameters that Groovy erases in constructors/methods (descriptors identical).
- Groovy gotchas that applied (see #16351): `static final` without `public` creates a property; `==` calls `equals()`; Closure/SAM coercions; `@CompileStatic` with nested classes. All CI regression fixes found on the umbrella branch are included in the end state.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6280549248
**Update: this branch now carries a different temporary CI commit (BLOCKER before merge).**
The earlier `skipTests`/`skipCodeStyle` flag in `gradle.properties` did not help enough: the functional jobs still compile the whole repository (about 57 minutes each) on every push, so it only saved around a fifth of the time. It has been removed.
In its place, every PR in this stack except #16576 (the one closest to 10.0.x) carries one temporary commit, `CHANGEME FOR ACCEPTANCE: disable PR workflow triggers`. It changes the `pull_request:` trigger of each workflow to `branches: ['CHANGEME-FOR-ACCEPTANCE']`, a branch that does not exist, so pushing, rebasing or force-pushing this branch starts no jobs.
**Condition for merging this PR:** that commit must be reverted on this branch first (`git revert` of the `CHANGEME FOR ACCEPTANCE` commit), and CI must then run and be green. **The absence of CI checks on this PR is deliberate and does not mean the code was tested.** The full build runs on #16576, and each PR gets it when the PR below it has merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6208488476
## 🚨 TestLens detected 1 failed test 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens CLI](https://testlens.app/docs/features/cli): `testlens pr 16604`
#### [CI / Build Grails Forge \(Java 21, indy\=false\)](https://github.com/apache/grails-core/actions/runs/38844120195/job/116790639478?pr=16604) > :test-core:test [grails-forge]
| Test | Runs | Flakiness |
|---|---|--:|
| AsciidoctorBuildSpec > an app with asciidoctor builds its guide, without the configuration cache the plugin does not support | ❌ | 0% 🟢 |
🏷️ Commit: 926ff8b45d47ecd27dd7ef2cc1f7c0e72d2a1f7f
▶️ Tests: 68997 executed
🟡 Checks: 141/167 completed
### Test Failures
<details><summary><strong>AsciidoctorBuildSpec > an app with asciidoctor builds its guide, without the configuration cache the plugin does not support</strong> (:test-core:test [grails-forge] in <a href="https://github.com/apache/grails-core/actions/runs/38844120195/job/116790639478?pr=16604">CI / Build Grails Forge (Java 21, indy=false)</a>)</summary>
```
org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/testasciidoctor1633551136823801834 with arguments [asciidoctor]
Output:
Calculating task graph as no cached configuration is available for tasks: asciidoctor
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'testasciidoctor1633551136823801834'.
> Could not resolve all artifacts for configuration 'classpath'.
> Could not resolve org.asciidoctor.jvm.convert:org.asciidoctor.jvm.convert.gradle.plugin:4.0.5.
Required by:
buildscript of root project 'testasciidoctor1633551136823801834'
> Could not resolve org.asciidoctor.jvm.convert:org.asciidoctor.jvm.convert.gradle.plugin:4.0.5.
> Could not get resource 'https://repo.grails.org/grails/restricted/org/asciidoctor/jvm/convert/org.asciidoctor.jvm.convert.gradle.plugin/4.0.5/org.asciidoctor.jvm.convert.gradle.plugin-4.0.5.pom'.
> Could not HEAD 'https://repo.grails.org/grails/restricted/org/asciidoctor/jvm/convert/org.asciidoctor.jvm.convert.gradle.plugin/4.0.5/org.asciidoctor.jvm.convert.gradle.plugin-4.0.5.pom'.
> repo.grails.org: Temporary failure in name resolution
> There is 1 more failure with an identical cause.
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights from a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.
BUILD FAILED in 43s
Configuration cache entry stored.
at org.gradle.testkit.runner.internal.DefaultGradleRunner.lambda$build$0(DefaultGradleRunner.java:275)
at org.gradle.testkit.runner.internal.DefaultGradleRunner.run(DefaultGradleRunner.java:374)
at org.gradle.testkit.runner.internal.DefaultGradleRunner.build(DefaultGradleRunner.java:273)
at org.grails.forge.utils.CommandSpec.executeGradle(CommandSpec.groovy:76)
at org.grails.forge.features.asciidoctor.AsciidoctorBuildSpec.an app with asciidoctor builds its guide, without the configuration cache the plugin does not support(AsciidoctorBuildSpec.groovy:33)
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 AsciidoctorBuildSpec > an app with asciidoctor builds its guide, without the configuration cache the plugin does not support <!-- uniqueId=[engine:spock]/[spec:org.grails.forge.features.asciidoctor.AsciidoctorBuildSpec]/[feature:$spock_feature_1_0] -->
Reuse successful test results:
🔲 ♻️ Only rerun the tests that failed or were muted before
Click the checkbox to trigger a rerun:
🔲 **Rerun jobs**
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6114390208
## ✅ All tests passed ✅
🏷️ Commit: 0faee65c0027897a18ed0b95bd40e2910d5c6628
▶️ Tests: 73617 executed
⚪️ Checks: 85/85 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6198191977
## ✅ All tests passed ✅
🏷️ Commit: ed53ccbdc7bdef2e4fc3649986ae3c7db3f435fd
▶️ Tests: 66996 executed
⚪️ Checks: 86/86 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.
borinquenkid closed pull request #16604: refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy
URL: https://github.com/apache/grails-core/pull/16604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6110189680
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16604?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `57.63657%` with `380 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 62.8398%. Comparing base ([`d5e670c`](https://app.codecov.io/gh/apache/grails-core/commit/d5e670ce03cbb84f7c8e92129fd9d3763e17ce23?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07c4880`](https://app.codecov.io/gh/apache/grails-core/commit/07c4880c8bf706b82a39327fd20ff85eaff6130c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16604?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../grails/web/gsp/GroovyPagesTemplateRenderer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fgsp%2FGroovyPagesTemplateRenderer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvZ3NwL0dyb292eVBhZ2VzVGVtcGxhdGVSZW5kZXJlci5ncm9vdnk=) | 40.8163% | [50 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...io/CachingGrailsConventionGroovyPageLocator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fgsp%2Fio%2FCachingGrailsConventionGroovyPageLocator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvZ3NwL2lvL0NhY2hpbmdHcmFpbHNDb252ZW50aW9uR3Jvb3Z5UGFnZUxvY2F0b3IuZ3Jvb3Z5) | 29.4118% | [41 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...oovy/org/grails/web/pages/GSPResponseWriter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fpages%2FGSPResponseWriter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvcGFnZXMvR1NQUmVzcG9uc2VXcml0ZXIuZ3Jvb3Z5) | 39.4366% | [41 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ils/web/servlet/view/GroovyPageViewResolver.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fview%2FGroovyPageViewResolver.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvc2VydmxldC92aWV3L0dyb292eVBhZ2VWaWV3UmVzb2x2ZXIuZ3Jvb3Z5) | 66.3793% | [25 Missing and 14 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...servlet/context/GrailsWebApplicationContext.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fservlet%2Fcontext%2FGrailsWebApplicationContext.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9ncmFpbHMvd2ViL3NlcnZsZXQvY29udGV4dC9HcmFpbHNXZWJBcHBsaWNhdGlvbkNvbnRleHQuZ3Jvb3Z5) | 38.0952% | [36 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...eb/gsp/io/GrailsConventionGroovyPageLocator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fgsp%2Fio%2FGrailsConventionGroovyPageLocator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvZ3NwL2lvL0dyYWlsc0NvbnZlbnRpb25Hcm9vdnlQYWdlTG9jYXRvci5ncm9vdnk=) | 51.2820% | [34 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/grails/web/servlet/view/GroovyPageView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fview%2FGroovyPageView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvc2VydmxldC92aWV3L0dyb292eVBhZ2VWaWV3Lmdyb292eQ==) | 31.4815% | [35 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ntext/support/WebRuntimeSpringConfiguration.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fcontext%2Fsupport%2FWebRuntimeSpringConfiguration.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2NvbnRleHQvc3VwcG9ydC9XZWJSdW50aW1lU3ByaW5nQ29uZmlndXJhdGlvbi5ncm9vdnk=) | 29.6296% | [15 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...g/grails/web/errors/GrailsExceptionResolver.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Ferrors%2FGrailsExceptionResolver.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2Vycm9ycy9HcmFpbHNFeGNlcHRpb25SZXNvbHZlci5ncm9vdnk=) | 87.7551% | [15 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ovy/org/grails/web/pages/GroovyPagesServlet.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fpages%2FGroovyPagesServlet.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvcGFnZXMvR3Jvb3Z5UGFnZXNTZXJ2bGV0Lmdyb292eQ==) | 67.3077% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [7 more](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## refactor/java-to-groovy-grails-web-url-mappings #16604 +/- ##
=========================================================================================
+ Coverage 62.7483% 62.8398% +0.0914%
- Complexity 31156 31244 +88
=========================================================================================
Files 2216 2216
Lines 108218 108164 -54
Branches 20400 20399 -1
=========================================================================================
+ Hits 67905 67970 +65
+ Misses 30567 30451 -116
+ Partials 9746 9743 -3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16604?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...b/servlet/boostrap/BootstrapArtefactHandler.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fboostrap%2FBootstrapArtefactHandler.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2Jvb3N0cmFwL0Jvb3RzdHJhcEFydGVmYWN0SGFuZGxlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | |
| [...g/grails/web/filters/HiddenHttpMethodFilter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Ffilters%2FHiddenHttpMethodFilter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2ZpbHRlcnMvSGlkZGVuSHR0cE1ldGhvZEZpbHRlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | |
| [.../org/grails/web/servlet/GrailsUrlPathHelper.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2FGrailsUrlPathHelper.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvR3JhaWxzVXJsUGF0aEhlbHBlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | |
| [...eb/servlet/mvc/AbstractTokenResponseHandler.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fmvc%2FAbstractTokenResponseHandler.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvbXZjL0Fic3RyYWN0VG9rZW5SZXNwb25zZUhhbmRsZXIuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | |
| [...b/servlet/context/support/GrailsEnvironment.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fservlet%2Fcontext%2Fsupport%2FGrailsEnvironment.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9ncmFpbHMvd2ViL3NlcnZsZXQvY29udGV4dC9zdXBwb3J0L0dyYWlsc0Vudmlyb25tZW50Lmdyb292eQ==) | `92.3077% <92.3077%> (ø)` | |
| [...rails/web/servlet/context/GrailsConfigUtils.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fcontext%2FGrailsConfigUtils.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2NvbnRleHQvR3JhaWxzQ29uZmlnVXRpbHMuZ3Jvb3Z5) | `96.1538% <94.4444%> (ø)` | |
| [...ervlet/boostrap/DefaultGrailsBootstrapClass.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fboostrap%2FDefaultGrailsBootstrapClass.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2Jvb3N0cmFwL0RlZmF1bHRHcmFpbHNCb290c3RyYXBDbGFzcy5ncm9vdnk=) | `90.9091% <90.9091%> (ø)` | |
| [...groovy/org/grails/web/servlet/view/NullView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fview%2FNullView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvc2VydmxldC92aWV3L051bGxWaWV3Lmdyb292eQ==) | `0.0000% <0.0000%> (ø)` | |
| [...ails/web/servlet/mvc/GrailsWebRequestFilter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fmvc%2FGrailsWebRequestFilter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvbXZjL0dyYWlsc1dlYlJlcXVlc3RGaWx0ZXIuZ3Jvb3Z5) | `84.3750% <86.9565%> (ø)` | |
| [...rc/main/groovy/grails/spring/WebBeanBuilder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fspring%2FWebBeanBuilder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9ncmFpbHMvc3ByaW5nL1dlYkJlYW5CdWlsZGVyLmdyb292eQ==) | `0.0000% <0.0000%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16604/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6155372439
## ✅ All tests passed ✅
🏷️ Commit: 4795bf05c81bb15596307cf7f10ece6b7fd1c0f3
▶️ Tests: 16442 executed
⚪️ Checks: 18/18 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6160251885
## ✅ All tests passed ✅
🏷️ Commit: 232014d7004f89378677d55d41f155cc92208878
▶️ Tests: 96562 executed
⚪️ Checks: 85/85 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6278023468
**Temporary CI flag on this stacked branch (BLOCKER before merge).**
This Java-to-Groovy chain is a stack of PRs, and every push to any of them starts the full CI matrix, which is more runner time than the ASF allows us. Every PR in the stack except the one closest to its release branch (#16576) therefore carries one temporary commit, `CHANGEME FOR ACCEPTANCE`, that adds this to the root `gradle.properties`:
```
skipTests=true
skipCodeStyle=true
```
With it, CI on this PR compiles but does not run tests or code style. The full build runs on #16576 (closest to 10.0.x), and each PR gets it when the PR below it has merged.
**Condition for merging this PR:** that `gradle.properties` block (and the `CHANGEME FOR ACCEPTANCE` commit) must be dropped from this branch first, and CI must then be green with the tests running. A green check on this PR as it stands does not mean the tests ran. Rollout of the commit is branch by branch, so a branch may not carry it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6110765670
## ✅ All tests passed ✅
🏷️ Commit: 07c4880c8bf706b82a39327fd20ff85eaff6130c
▶️ Tests: 96096 executed
⚪️ Checks: 83/83 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub) via notifications" <no...@grails.apache.org>.
testlens-app[bot] commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6607296067
## 🔎 No tests executed 🔎
🏷️ Commit: c4a53c6a04aa34aa6ffb96be3051f13ec1a83b0e
▶️ Tests: 0 executed
⚪️ Checks: 45/45 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-web-gsp, grails-web-mvc and grails-web-core to Groovy [grails-core]
Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.
borinquenkid commented on PR #16604:
URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6733988193
Moving this stacked draft to my fork (borinquenkid/grails-core, same branch name) to cut review noise while it is downstream of active work. The branch stays here and will be reopened upstream when it is ready to be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org