You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2025/07/09 01:22:31 UTC
[PR] [HUDI-8401] Upgrade current table version to table version 9 [hudi]
linliu-code opened a new pull request, #13533:
URL: https://github.com/apache/hudi/pull/13533
### Change Logs
Upgrade current table version to be 9.
### Impact
None.
### Risk level (write none, low medium or high below)
Low.
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217452840
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeModeEventTimeOrdering.scala:
##########
@@ -32,19 +32,23 @@ import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase.validateTableConf
class TestMergeModeEventTimeOrdering extends HoodieSparkSqlTestBase {
// TODO(HUDI-8938): add "mor,6,true", "mor,6,false" after the fix
- Seq("cow,8,true", "cow,8,false", "cow,6,true", "cow,6,false",
- "mor,8,true", "mor,8,false").foreach { args =>
+ Seq("cow,current,true", "cow,current,false", "cow,6,true", "cow,6,false",
+ "mor,current,true", "mor,current,false").foreach { args =>
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3086583253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 764faac06d609887b485ffc540e46d4933c0d45d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823)
* bf0f0f4fd152355bb32c244374c6589ad98b0b4e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214362038
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/compact/ITTestHoodieFlinkCompactor.java:
##########
@@ -239,9 +239,9 @@ public void testHoodieFlinkCompactorWithUpgradeAndDowngrade(boolean upgrade) thr
if (upgrade) {
metaClient.getTableConfig().setTableVersion(HoodieTableVersion.SIX);
HoodieTableConfig.update(metaClient.getStorage(), metaClient.getMetaPath(), metaClient.getTableConfig().getProps());
- new UpgradeDowngrade(metaClient, writeClient.getConfig(), writeClient.getEngineContext(), FlinkUpgradeDowngradeHelper.getInstance()).run(HoodieTableVersion.EIGHT, "none");
+ new UpgradeDowngrade(metaClient, writeClient.getConfig(), writeClient.getEngineContext(), FlinkUpgradeDowngradeHelper.getInstance()).run(HoodieTableVersion.NINE, "none");
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3079434111
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85de412f4aa6ff68656f44905008e6b25fba9aa7 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785)
* 90cdefe412df3dcf317079d628c24f171a82de55 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786)
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3085026213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 0d100fe98c7eb2d48c16d3c23d184560dc22f8f6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792)
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* 0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217135841
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -321,7 +342,7 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
// incremental query from commit2Time
// validate incremental queries only for table version 8
// 1.0 reader (table version 8) supports incremental query reads using completion time
- if (tableVersion.equals("EIGHT")) {
+ if (tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
same comment as above
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSevenToEightUpgrade.scala:
##########
@@ -75,7 +75,7 @@ class TestSevenToEightUpgrade extends RecordLevelIndexTestBase {
metaClient = getLatestMetaClient(true)
// assert table version is eight and the partition fields in table config has partition type
- assertEquals(HoodieTableVersion.EIGHT, metaClient.getTableConfig.getTableVersion)
+ assertEquals(HoodieTableVersion.current(), metaClient.getTableConfig.getTableVersion)
Review Comment:
fix comment in L 77 (eight -> nine)
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/TestCommonClientUtils.java:
##########
@@ -95,14 +95,13 @@ private static Stream<Arguments> provideValidTableVersionWriteVersionPairs() {
generateSameVersionCases()
),
Stream.of(
- // Rule 3: special case - upgrade scenario (table > 6, table < 9, writer = 6)
+ // Rule 3: downgrade scenarios
Arguments.of(HoodieTableVersion.SEVEN, HoodieTableVersion.SIX, true),
Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SIX, true),
-
- // Rule 4: otherwise disallowed - table > writer (except special case above)
- Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX, false),
- Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.EIGHT, false),
- Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SEVEN, false)
+ Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX, true),
Review Comment:
where are the disallowed combinations.
for eg, 9 -> 5, 8 -> 5, 6 -> 5
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -207,7 +228,7 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
.mode(SaveMode.Append)
.save(basePath)
HoodieTestUtils.validateTableConfig(storage, basePath, expectedConfigs, nonExistentConfigs)
- val commit2CompletionTime = if (tableVersion.equals("EIGHT")) {
+ val commit2CompletionTime = if (tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
same here
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -670,15 +670,15 @@ public void testSchemaEvolution(String tableType, boolean useUserProvidedSchema,
private static Stream<Arguments> continuousModeArgs() {
return Stream.of(
- Arguments.of("AVRO", "EIGHT"),
- Arguments.of("SPARK", "EIGHT"),
+ Arguments.of("AVRO", "CURRENT"),
+ Arguments.of("SPARK", "CURRENT"),
Review Comment:
can we do just 1 combo for EIGHT (AVRO, EIGHT)
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeModeCommitTimeOrdering.scala:
##########
@@ -276,7 +279,8 @@ class TestMergeModeCommitTimeOrdering extends HoodieSparkSqlTestBase {
storage, tmp.getCanonicalPath, expectedMergeConfigs, nonExistentConfigs)
// TODO(HUDI-8840): enable MERGE INTO with deletes
- val shouldTestMergeIntoDelete = setRecordMergeConfigs && tableVersion.toInt == 8
+ val shouldTestMergeIntoDelete = setRecordMergeConfigs &&
+ tableVersion.toInt == HoodieTableVersion.current().versionCode()
Review Comment:
is this not supposed to be `>= version 8`
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeModeEventTimeOrdering.scala:
##########
@@ -32,19 +32,23 @@ import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase.validateTableConf
class TestMergeModeEventTimeOrdering extends HoodieSparkSqlTestBase {
// TODO(HUDI-8938): add "mor,6,true", "mor,6,false" after the fix
- Seq("cow,8,true", "cow,8,false", "cow,6,true", "cow,6,false",
- "mor,8,true", "mor,8,false").foreach { args =>
+ Seq("cow,current,true", "cow,current,false", "cow,6,true", "cow,6,false",
+ "mor,current,true", "mor,current,false").foreach { args =>
Review Comment:
can we include below combos as well
cow, eight, true
mor, eight, true
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -226,7 +247,7 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
// incremental view
// validate incremental queries only for table version 8
// 1.0 reader (table version 8) supports incremental query reads using completion time
- if (tableVersion.equals("EIGHT")) {
+ if (tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
same comment as above
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -185,7 +205,8 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
Seq(HoodieTableConfig.PRECOMBINE_FIELD.key)
}).asJava
HoodieTestUtils.validateTableConfig(storage, basePath, expectedConfigs, nonExistentConfigs)
- val commit1CompletionTime = if (tableVersion.equals("EIGHT")) {
+ val commit1CompletionTime = if (
+ tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
can we do tableVersion.greaterThanOrEquals () so that we don't need to fix this in future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217447354
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -226,7 +247,7 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
// incremental view
// validate incremental queries only for table version 8
// 1.0 reader (table version 8) supports incremental query reads using completion time
- if (tableVersion.equals("EIGHT")) {
+ if (tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
Done.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -321,7 +342,7 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
// incremental query from commit2Time
// validate incremental queries only for table version 8
// 1.0 reader (table version 8) supports incremental query reads using completion time
- if (tableVersion.equals("EIGHT")) {
+ if (tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3079896577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 565449dd29dfc09235a4e56d9c7a46980df71f6e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3094606145
can you check CI failure @linliu-code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217447250
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -207,7 +228,7 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
.mode(SaveMode.Append)
.save(basePath)
HoodieTestUtils.validateTableConfig(storage, basePath, expectedConfigs, nonExistentConfigs)
- val commit2CompletionTime = if (tableVersion.equals("EIGHT")) {
+ val commit2CompletionTime = if (tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3095002708
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"triggerType" : "PUSH"
}, {
"hash" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882",
"triggerID" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"triggerType" : "PUSH"
}, {
"hash" : "5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6899",
"triggerID" : "5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 4cab4f096bfe078232ce023e000c831443c47b0f UNKNOWN
* 5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6899)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3092569984
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* bf0f0f4fd152355bb32c244374c6589ad98b0b4e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825)
* 4cab4f096bfe078232ce023e000c831443c47b0f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3075295147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46c5ee66d3ee523acb0eddae52f80f7bf27fc352 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3050737930
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87d689d4204c8a1e9b6bccfb6d97490c90ff2a74 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3086700272
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* bf0f0f4fd152355bb32c244374c6589ad98b0b4e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217447687
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSevenToEightUpgrade.scala:
##########
@@ -75,7 +75,7 @@ class TestSevenToEightUpgrade extends RecordLevelIndexTestBase {
metaClient = getLatestMetaClient(true)
// assert table version is eight and the partition fields in table config has partition type
- assertEquals(HoodieTableVersion.EIGHT, metaClient.getTableConfig.getTableVersion)
+ assertEquals(HoodieTableVersion.current(), metaClient.getTableConfig.getTableVersion)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3079421795
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85de412f4aa6ff68656f44905008e6b25fba9aa7 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785)
* 90cdefe412df3dcf317079d628c24f171a82de55 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3079622386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90cdefe412df3dcf317079d628c24f171a82de55 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786)
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 565449dd29dfc09235a4e56d9c7a46980df71f6e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2211588673
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/TestCommonClientUtils.java:
##########
@@ -95,14 +95,16 @@ private static Stream<Arguments> provideValidTableVersionWriteVersionPairs() {
generateSameVersionCases()
),
Stream.of(
- // Rule 3: special case - upgrade scenario (table > 6, table < 9, writer = 6)
+ // Rule 3: downgrade scenarios
Arguments.of(HoodieTableVersion.SEVEN, HoodieTableVersion.SIX, true),
Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SIX, true),
+ Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX, true),
// Rule 4: otherwise disallowed - table > writer (except special case above)
Review Comment:
Fix the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217447134
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -185,7 +205,8 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
Seq(HoodieTableConfig.PRECOMBINE_FIELD.key)
}).asJava
HoodieTestUtils.validateTableConfig(storage, basePath, expectedConfigs, nonExistentConfigs)
- val commit1CompletionTime = if (tableVersion.equals("EIGHT")) {
+ val commit1CompletionTime = if (
+ tableVersion.equals("CURRENT") || tableVersion.equals("EIGHT")) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3079416549
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85de412f4aa6ff68656f44905008e6b25fba9aa7 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785)
* 90cdefe412df3dcf317079d628c24f171a82de55 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3078545868
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a54fb467bcda204400e3330ddc582fbe67a7f087 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759)
* 85de412f4aa6ff68656f44905008e6b25fba9aa7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214194802
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/compact/ITTestHoodieFlinkCompactor.java:
##########
@@ -239,9 +239,9 @@ public void testHoodieFlinkCompactorWithUpgradeAndDowngrade(boolean upgrade) thr
if (upgrade) {
metaClient.getTableConfig().setTableVersion(HoodieTableVersion.SIX);
HoodieTableConfig.update(metaClient.getStorage(), metaClient.getMetaPath(), metaClient.getTableConfig().getProps());
- new UpgradeDowngrade(metaClient, writeClient.getConfig(), writeClient.getEngineContext(), FlinkUpgradeDowngradeHelper.getInstance()).run(HoodieTableVersion.EIGHT, "none");
+ new UpgradeDowngrade(metaClient, writeClient.getConfig(), writeClient.getEngineContext(), FlinkUpgradeDowngradeHelper.getInstance()).run(HoodieTableVersion.NINE, "none");
Review Comment:
instead of HoodieTableVersion.NINE, shouldn't we do `HoodieTableVersion.current()`
but then we also need to fix the tests properly.
this was written from 6 to 8 and then downgrading from 8 to 6.
now that we have 9, should this become 8 to 9 and 9 back to 8.
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -670,15 +670,15 @@ public void testSchemaEvolution(String tableType, boolean useUserProvidedSchema,
private static Stream<Arguments> continuousModeArgs() {
return Stream.of(
- Arguments.of("AVRO", "EIGHT"),
- Arguments.of("SPARK", "EIGHT"),
+ Arguments.of("AVRO", "NINE"),
Review Comment:
similar comment as above to use `HoodieTableVersion`.
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestStreamerUtil.java:
##########
@@ -88,7 +88,7 @@ void testInitTableIfNotExists() throws IOException {
assertArrayEquals(metaClient1.getTableConfig().getPartitionFields().get(), new String[] {"p0", "p1"});
assertEquals(metaClient1.getTableConfig().getPreCombineField(), "ts");
assertEquals(metaClient1.getTableConfig().getKeyGeneratorClassName(), SimpleAvroKeyGenerator.class.getName());
- assertEquals(HoodieTableVersion.EIGHT, metaClient1.getTableConfig().getTableVersion());
+ assertEquals(HoodieTableVersion.NINE, metaClient1.getTableConfig().getTableVersion());
Review Comment:
lets do `HoodieTableVersion.current()`
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -98,17 +98,17 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
@ParameterizedTest
@CsvSource(Array(
// Inferred as COMMIT_TIME_ORDERING
- "AVRO, AVRO, avro, false,,,EIGHT", "AVRO, SPARK, parquet, false,,,EIGHT",
- "SPARK, AVRO, parquet, false,,,EIGHT", "SPARK, SPARK, parquet, false,,,EIGHT",
+ "AVRO, AVRO, avro, false,,,CURRENT", "AVRO, SPARK, parquet, false,,,CURRENT",
Review Comment:
we should also think about the combinations we are running here.
previously we were running it for v6 and v8.
now, we should be running it for 6,8 and 9.
I am not saying every test should be parametrized.
but few such functional tests we can run it for all table versions.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestUpgradeOrDowngradeProcedure.scala:
##########
@@ -59,10 +59,10 @@ class TestUpgradeOrDowngradeProcedure extends HoodieSparkProcedureTestBase {
var metaClient = createMetaClient(spark, tablePath)
// verify hoodie.table.version of the original table
- assertResult(HoodieTableVersion.EIGHT.versionCode) {
+ assertResult(HoodieTableVersion.NINE.versionCode) {
metaClient.getTableConfig.getTableVersion.versionCode()
}
- assertTableVersionFromPropertyFile(metaClient, HoodieTableVersion.EIGHT.versionCode)
+ assertTableVersionFromPropertyFile(metaClient, HoodieTableVersion.NINE.versionCode)
Review Comment:
`HoodieTableVersion.current()`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToNineUpgradeHandler.java:
##########
@@ -30,6 +31,11 @@ public class EightToNineUpgradeHandler implements UpgradeHandler {
@Override
public Map<ConfigProperty, String> upgrade(HoodieWriteConfig config, HoodieEngineContext context,
String instantTime, SupportsUpgradeDowngrade upgradeDowngradeHelper) {
+ // If auto upgrade is disabled, set writer version to 8 and return
+ if (!config.autoUpgrade()) {
+ config.setValue(HoodieWriteConfig.WRITE_TABLE_VERSION, String.valueOf(HoodieTableVersion.EIGHT.versionCode()));
+ return Collections.emptyMap();
+ }
Review Comment:
why are we not triggering rollbacks and full compaction when upgrading to V 9?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeModeCommitTimeOrdering.scala:
##########
@@ -31,7 +31,7 @@ import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase.validateTableConf
class TestMergeModeCommitTimeOrdering extends HoodieSparkSqlTestBase {
Seq(
- "cow,8,false,false", "cow,8,false,true", "cow,8,true,false",
+ "cow,9,false,false", "cow,8,false,true", "cow,9,true,false",
Review Comment:
For these test parameters, can we take in `HoodieTableVersion` as an argument.
then we can set it to `HoodieTableVersion.current()` here. and in validations also, we can leverage `HoodieTableVersion.current().versionCode`.
w/ this change, we don't need to keep fixing these tests when we upgrade to v 10. should just work oob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3085807600
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* 0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808)
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3085796906
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* 0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808)
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214453021
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestUpgradeOrDowngradeProcedure.scala:
##########
@@ -59,10 +59,10 @@ class TestUpgradeOrDowngradeProcedure extends HoodieSparkProcedureTestBase {
var metaClient = createMetaClient(spark, tablePath)
// verify hoodie.table.version of the original table
- assertResult(HoodieTableVersion.EIGHT.versionCode) {
+ assertResult(HoodieTableVersion.NINE.versionCode) {
metaClient.getTableConfig.getTableVersion.versionCode()
}
- assertTableVersionFromPropertyFile(metaClient, HoodieTableVersion.EIGHT.versionCode)
+ assertTableVersionFromPropertyFile(metaClient, HoodieTableVersion.NINE.versionCode)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214407441
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestStreamerUtil.java:
##########
@@ -88,7 +88,7 @@ void testInitTableIfNotExists() throws IOException {
assertArrayEquals(metaClient1.getTableConfig().getPartitionFields().get(), new String[] {"p0", "p1"});
assertEquals(metaClient1.getTableConfig().getPreCombineField(), "ts");
assertEquals(metaClient1.getTableConfig().getKeyGeneratorClassName(), SimpleAvroKeyGenerator.class.getName());
- assertEquals(HoodieTableVersion.EIGHT, metaClient1.getTableConfig().getTableVersion());
+ assertEquals(HoodieTableVersion.NINE, metaClient1.getTableConfig().getTableVersion());
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3085825610
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* 0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808)
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217385494
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/TestCommonClientUtils.java:
##########
@@ -95,14 +95,13 @@ private static Stream<Arguments> provideValidTableVersionWriteVersionPairs() {
generateSameVersionCases()
),
Stream.of(
- // Rule 3: special case - upgrade scenario (table > 6, table < 9, writer = 6)
+ // Rule 3: downgrade scenarios
Arguments.of(HoodieTableVersion.SEVEN, HoodieTableVersion.SIX, true),
Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SIX, true),
-
- // Rule 4: otherwise disallowed - table > writer (except special case above)
- Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX, false),
- Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.EIGHT, false),
- Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SEVEN, false)
+ Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX, true),
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217458668
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -670,15 +670,15 @@ public void testSchemaEvolution(String tableType, boolean useUserProvidedSchema,
private static Stream<Arguments> continuousModeArgs() {
return Stream.of(
- Arguments.of("AVRO", "EIGHT"),
- Arguments.of("SPARK", "EIGHT"),
+ Arguments.of("AVRO", "CURRENT"),
+ Arguments.of("SPARK", "CURRENT"),
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3094872691
> @linliu-code :
>
> * Can you list the increase in total test run time w/ additional combinations we have added.
We added more test cases to `TestMORDataSource.testCount`, which increased about 2 minutes in total.
We aslo added some test cases to `TestMergeModeEventTimeOrdering`, which totally took about 3 minutes and the two additional test cases took about 30 seconds.
> * Also, can you point me to the test case where cur table is in v6 and user wants to upgrade to just v8. I remember asking you to get one sanity functional test account for this scenario.
`TestSevenToEightUpgrade` implements the similar logic: Table version 9 is downgraded to version 7, and then upgrade to only 8 by setting the write table version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3074960241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87d689d4204c8a1e9b6bccfb6d97490c90ff2a74 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655)
* 46c5ee66d3ee523acb0eddae52f80f7bf27fc352 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3078857838
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85de412f4aa6ff68656f44905008e6b25fba9aa7 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3076145399
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a54fb467bcda204400e3330ddc582fbe67a7f087 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3075989060
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46c5ee66d3ee523acb0eddae52f80f7bf27fc352 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749)
* a54fb467bcda204400e3330ddc582fbe67a7f087 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3075986353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46c5ee66d3ee523acb0eddae52f80f7bf27fc352 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749)
* a54fb467bcda204400e3330ddc582fbe67a7f087 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3086572057
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 764faac06d609887b485ffc540e46d4933c0d45d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823)
* bf0f0f4fd152355bb32c244374c6589ad98b0b4e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3079439932
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90cdefe412df3dcf317079d628c24f171a82de55 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786)
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3084500571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 565449dd29dfc09235a4e56d9c7a46980df71f6e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787)
* 0d100fe98c7eb2d48c16d3c23d184560dc22f8f6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214474603
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToNineUpgradeHandler.java:
##########
@@ -30,6 +31,11 @@ public class EightToNineUpgradeHandler implements UpgradeHandler {
@Override
public Map<ConfigProperty, String> upgrade(HoodieWriteConfig config, HoodieEngineContext context,
String instantTime, SupportsUpgradeDowngrade upgradeDowngradeHelper) {
+ // If auto upgrade is disabled, set writer version to 8 and return
+ if (!config.autoUpgrade()) {
+ config.setValue(HoodieWriteConfig.WRITE_TABLE_VERSION, String.valueOf(HoodieTableVersion.EIGHT.versionCode()));
+ return Collections.emptyMap();
+ }
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3050740610
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87d689d4204c8a1e9b6bccfb6d97490c90ff2a74 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3092627531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"triggerType" : "PUSH"
}, {
"hash" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882",
"triggerID" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 4cab4f096bfe078232ce023e000c831443c47b0f UNKNOWN
* 6b8a448f6d716a1292ffb5e455197e157b2da234 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3092593816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"triggerType" : "PUSH"
}, {
"hash" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882",
"triggerID" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* bf0f0f4fd152355bb32c244374c6589ad98b0b4e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825)
* 4cab4f096bfe078232ce023e000c831443c47b0f UNKNOWN
* 6b8a448f6d716a1292ffb5e455197e157b2da234 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3092578705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"triggerType" : "PUSH"
}, {
"hash" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* bf0f0f4fd152355bb32c244374c6589ad98b0b4e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825)
* 4cab4f096bfe078232ce023e000c831443c47b0f UNKNOWN
* 6b8a448f6d716a1292ffb5e455197e157b2da234 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217452931
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeModeEventTimeOrdering.scala:
##########
@@ -32,19 +32,23 @@ import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase.validateTableConf
class TestMergeModeEventTimeOrdering extends HoodieSparkSqlTestBase {
// TODO(HUDI-8938): add "mor,6,true", "mor,6,false" after the fix
- Seq("cow,8,true", "cow,8,false", "cow,6,true", "cow,6,false",
- "mor,8,true", "mor,8,false").foreach { args =>
+ Seq("cow,current,true", "cow,current,false", "cow,6,true", "cow,6,false",
+ "mor,current,true", "mor,current,false").foreach { args =>
Review Comment:
Aslo add "mor,6,true", "mor,6,false" since HUDI-8938 is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2213632401
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngradeUtils.java:
##########
@@ -125,7 +125,9 @@ public static void syncCompactionRequestedFileToAuxiliaryFolder(HoodieTable tabl
});
}
- static void updateMetadataTableVersion(HoodieEngineContext context, HoodieTableVersion toVersion, HoodieTableMetaClient dataMetaClient) throws HoodieIOException {
+ static void updateMetadataTableVersion(HoodieEngineContext context,
Review Comment:
Cosmetic change. Could be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3084930485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 0d100fe98c7eb2d48c16d3c23d184560dc22f8f6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792)
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3094857590
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"triggerType" : "PUSH"
}, {
"hash" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882",
"triggerID" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"triggerType" : "PUSH"
}, {
"hash" : "5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 4cab4f096bfe078232ce023e000c831443c47b0f UNKNOWN
* 6b8a448f6d716a1292ffb5e455197e157b2da234 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882)
* 5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214351511
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToNineUpgradeHandler.java:
##########
@@ -30,6 +31,11 @@ public class EightToNineUpgradeHandler implements UpgradeHandler {
@Override
public Map<ConfigProperty, String> upgrade(HoodieWriteConfig config, HoodieEngineContext context,
String instantTime, SupportsUpgradeDowngrade upgradeDowngradeHelper) {
+ // If auto upgrade is disabled, set writer version to 8 and return
+ if (!config.autoUpgrade()) {
+ config.setValue(HoodieWriteConfig.WRITE_TABLE_VERSION, String.valueOf(HoodieTableVersion.EIGHT.versionCode()));
+ return Collections.emptyMap();
+ }
Review Comment:
Not sure if that is a universal requirement. I added it to the upgrade/downgrade PR. I can add it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3086451524
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 764faac06d609887b485ffc540e46d4933c0d45d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3074973616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87d689d4204c8a1e9b6bccfb6d97490c90ff2a74 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655)
* 46c5ee66d3ee523acb0eddae52f80f7bf27fc352 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3079467336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90cdefe412df3dcf317079d628c24f171a82de55 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786)
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 565449dd29dfc09235a4e56d9c7a46980df71f6e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3084484456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 565449dd29dfc09235a4e56d9c7a46980df71f6e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787)
* 0d100fe98c7eb2d48c16d3c23d184560dc22f8f6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2213948378
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/TestCommonClientUtils.java:
##########
@@ -95,14 +95,16 @@ private static Stream<Arguments> provideValidTableVersionWriteVersionPairs() {
generateSameVersionCases()
),
Stream.of(
- // Rule 3: special case - upgrade scenario (table > 6, table < 9, writer = 6)
+ // Rule 3: downgrade scenarios
Arguments.of(HoodieTableVersion.SEVEN, HoodieTableVersion.SIX, true),
Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SIX, true),
+ Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX, true),
// Rule 4: otherwise disallowed - table > writer (except special case above)
Review Comment:
done.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngradeUtils.java:
##########
@@ -125,7 +125,9 @@ public static void syncCompactionRequestedFileToAuxiliaryFolder(HoodieTable tabl
});
}
- static void updateMetadataTableVersion(HoodieEngineContext context, HoodieTableVersion toVersion, HoodieTableMetaClient dataMetaClient) throws HoodieIOException {
+ static void updateMetadataTableVersion(HoodieEngineContext context,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214407717
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -98,17 +98,17 @@ class TestMORDataSource extends HoodieSparkClientTestBase with SparkDatasetMixin
@ParameterizedTest
@CsvSource(Array(
// Inferred as COMMIT_TIME_ORDERING
- "AVRO, AVRO, avro, false,,,EIGHT", "AVRO, SPARK, parquet, false,,,EIGHT",
- "SPARK, AVRO, parquet, false,,,EIGHT", "SPARK, SPARK, parquet, false,,,EIGHT",
+ "AVRO, AVRO, avro, false,,,CURRENT", "AVRO, SPARK, parquet, false,,,CURRENT",
Review Comment:
Add v8, and current.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214429700
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeModeCommitTimeOrdering.scala:
##########
@@ -31,7 +31,7 @@ import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase.validateTableConf
class TestMergeModeCommitTimeOrdering extends HoodieSparkSqlTestBase {
Seq(
- "cow,8,false,false", "cow,8,false,true", "cow,8,true,false",
+ "cow,9,false,false", "cow,8,false,true", "cow,9,true,false",
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3094901566
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
}, {
"hash" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6825",
"triggerID" : "bf0f0f4fd152355bb32c244374c6589ad98b0b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cab4f096bfe078232ce023e000c831443c47b0f",
"triggerType" : "PUSH"
}, {
"hash" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882",
"triggerID" : "6b8a448f6d716a1292ffb5e455197e157b2da234",
"triggerType" : "PUSH"
}, {
"hash" : "5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6899",
"triggerID" : "5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 4cab4f096bfe078232ce023e000c831443c47b0f UNKNOWN
* 6b8a448f6d716a1292ffb5e455197e157b2da234 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6882)
* 5fb1b69a9f6791ea96888b5ba2526d9ba2cf9c0b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6899)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217451193
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestMergeModeCommitTimeOrdering.scala:
##########
@@ -276,7 +279,8 @@ class TestMergeModeCommitTimeOrdering extends HoodieSparkSqlTestBase {
storage, tmp.getCanonicalPath, expectedMergeConfigs, nonExistentConfigs)
// TODO(HUDI-8840): enable MERGE INTO with deletes
- val shouldTestMergeIntoDelete = setRecordMergeConfigs && tableVersion.toInt == 8
+ val shouldTestMergeIntoDelete = setRecordMergeConfigs &&
+ tableVersion.toInt == HoodieTableVersion.current().versionCode()
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3084770760
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 0d100fe98c7eb2d48c16d3c23d184560dc22f8f6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3084933985
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* 0d100fe98c7eb2d48c16d3c23d184560dc22f8f6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792)
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* 0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3085450190
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* 0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2214457787
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -670,15 +670,15 @@ public void testSchemaEvolution(String tableType, boolean useUserProvidedSchema,
private static Stream<Arguments> continuousModeArgs() {
return Stream.of(
- Arguments.of("AVRO", "EIGHT"),
- Arguments.of("SPARK", "EIGHT"),
+ Arguments.of("AVRO", "NINE"),
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3086067632
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820)
* 764faac06d609887b485ffc540e46d4933c0d45d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3086269389
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6785",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
}, {
"hash" : "90cdefe412df3dcf317079d628c24f171a82de55",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6786",
"triggerID" : "90cdefe412df3dcf317079d628c24f171a82de55",
"triggerType" : "PUSH"
}, {
"hash" : "8ba448c09a19927b912654734c59f102df97e40b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ba448c09a19927b912654734c59f102df97e40b",
"triggerType" : "PUSH"
}, {
"hash" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6787",
"triggerID" : "565449dd29dfc09235a4e56d9c7a46980df71f6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6792",
"triggerID" : "0d100fe98c7eb2d48c16d3c23d184560dc22f8f6",
"triggerType" : "PUSH"
}, {
"hash" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb",
"triggerType" : "PUSH"
}, {
"hash" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6808",
"triggerID" : "0aeb56fcf3fb441b2aa0ce733db1f00a7dc6fc6f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9a032def2f615f43939e752e0a083d865077bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9a032def2f615f43939e752e0a083d865077bd",
"triggerType" : "PUSH"
}, {
"hash" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820",
"triggerID" : "161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2",
"triggerType" : "PUSH"
}, {
"hash" : "764faac06d609887b485ffc540e46d4933c0d45d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823",
"triggerID" : "764faac06d609887b485ffc540e46d4933c0d45d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ba448c09a19927b912654734c59f102df97e40b UNKNOWN
* fc8a1f0a7c14b6e65482974e744fcfbe65bc87cb UNKNOWN
* ad9a032def2f615f43939e752e0a083d865077bd UNKNOWN
* 161c475d2e9e7a2ed4085e81dfc7e6e3dd768ee2 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6820)
* 764faac06d609887b485ffc540e46d4933c0d45d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6823)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3050884924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87d689d4204c8a1e9b6bccfb6d97490c90ff2a74 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3078532627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6655",
"triggerID" : "87d689d4204c8a1e9b6bccfb6d97490c90ff2a74",
"triggerType" : "PUSH"
}, {
"hash" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6749",
"triggerID" : "46c5ee66d3ee523acb0eddae52f80f7bf27fc352",
"triggerType" : "PUSH"
}, {
"hash" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759",
"triggerID" : "a54fb467bcda204400e3330ddc582fbe67a7f087",
"triggerType" : "PUSH"
}, {
"hash" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85de412f4aa6ff68656f44905008e6b25fba9aa7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a54fb467bcda204400e3330ddc582fbe67a7f087 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6759)
* 85de412f4aa6ff68656f44905008e6b25fba9aa7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #13533:
URL: https://github.com/apache/hudi/pull/13533#issuecomment-3094608530
@linliu-code :
- Can you list the increase in total test run time w/ additional combinations we have added.
- Also, can you point me to the test case where cur table is in v6 and user wants to upgrade to just v8. I remember asking you to get one sanity functional test account for this scenario.
Once we have these addressed, we are good to land the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8401] Upgrade current table version to 9 [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #13533:
URL: https://github.com/apache/hudi/pull/13533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org