You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/01 09:02:52 UTC

[GitHub] [arrow] rymurr commented on a change in pull request #7275: ARROW-6110: [Java][Integration] Support LargeList Type and add integration test with C++

rymurr commented on a change in pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#discussion_r448222516



##########
File path: java/vector/src/main/java/org/apache/arrow/vector/BitVectorHelper.java
##########
@@ -73,6 +87,28 @@ public static void setBit(ArrowBuf validityBuffer, int index) {
     validityBuffer.setByte(byteIndex, currentByte);
   }
 
+  /**
+   * Set the bit at provided index to 1.
+   *
+   * @param validityBuffer validity buffer of the vector
+   * @param index index to be set
+   */
+  public static void setBit(ArrowBuf validityBuffer, long index) {
+    // it can be observed that some logic is duplicate of the logic in setValidityBit.

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org