You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/06 22:06:23 UTC
[GitHub] [airflow] potiuk opened a new pull request #10209: You can now trigger apache/airflow sync via Github Web UI
potiuk opened a new pull request #10209:
URL: https://github.com/apache/airflow/pull/10209
We are using newly added feature of GitHub to add manually triggered
workflow to enable manually-triggered force-syncing of your fork
with apache/airflow.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10209: You can sync your fork master with apache/airflow master via UI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10209:
URL: https://github.com/apache/airflow/pull/10209#discussion_r466825085
##########
File path: CONTRIBUTING.rst
##########
@@ -862,6 +865,19 @@ commands:
# Check JS code in .js and .html files, report any errors/warnings and fix them if possible
yarn run lint:fix
+How to sync your fork
+=====================
+
+When you have your fork, you should periodically synchronize the master of your fork with the
+Apache Airflow master. In order to do that you can ``git pull`` to your local git repository from
Review comment:
```suggestion
Apache Airflow master. In order to do that you can ``git pull --rebase`` to your local git repository from
```
Should we explicitly recommend fetch and rebase? Just in case someone one read this and skips rest of the information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-commenter commented on pull request #10209: You can now trigger apache/airflow sync via Github Web UI
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10209:
URL: https://github.com/apache/airflow/pull/10209#issuecomment-670219050
# [Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=h1) Report
> Merging [#10209](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d79e7221de76f01b5cd36c15224b59e8bb451c90&el=desc) will **decrease** coverage by `54.30%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/10209/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10209 +/- ##
===========================================
- Coverage 89.41% 35.11% -54.31%
===========================================
Files 1037 1037
Lines 50011 50011
===========================================
- Hits 44717 17559 -27158
- Misses 5294 32452 +27158
```
| Flag | Coverage Δ | |
|---|---|---|
| #kubernetes-tests-3.6-9.6 | `?` | |
| #kubernetes-tests-image-3.6-v1.16.9 | `?` | |
| #kubernetes-tests-image-3.6-v1.17.5 | `?` | |
| #kubernetes-tests-image-3.6-v1.18.6 | `?` | |
| #kubernetes-tests-image-3.7-v1.16.9 | `?` | |
| #kubernetes-tests-image-3.7-v1.17.5 | `?` | |
| #kubernetes-tests-image-3.7-v1.18.6 | `?` | |
| #mysql-tests-Core-3.7-5.7 | `?` | |
| #mysql-tests-Core-3.8-5.7 | `?` | |
| #mysql-tests-Integration-3.7-5.7 | `34.75% <ø> (ø)` | |
| #mysql-tests-Integration-3.8-5.7 | `?` | |
| #postgres-tests-Core-3.6-10 | `?` | |
| #postgres-tests-Core-3.6-9.6 | `?` | |
| #postgres-tests-Core-3.7-10 | `?` | |
| #postgres-tests-Core-3.7-9.6 | `?` | |
| #postgres-tests-Integration-3.6-10 | `?` | |
| #postgres-tests-Integration-3.6-9.6 | `?` | |
| #postgres-tests-Integration-3.7-10 | `?` | |
| #postgres-tests-Integration-3.7-9.6 | `?` | |
| #sqlite-tests-Core-3.6 | `?` | |
| #sqlite-tests-Core-3.8 | `?` | |
| #sqlite-tests-Integration-3.6 | `34.18% <ø> (ø)` | |
| #sqlite-tests-Integration-3.8 | `34.44% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/contrib/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL19faW5pdF9fLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [906 more](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=footer). Last update [d79e722...a0dec32](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10209: You can sync your fork master with apache/airflow master via UI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10209:
URL: https://github.com/apache/airflow/pull/10209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-commenter edited a comment on pull request #10209: You can now trigger apache/airflow sync via Github Web UI
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10209:
URL: https://github.com/apache/airflow/pull/10209#issuecomment-670219050
# [Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=h1) Report
> Merging [#10209](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d79e7221de76f01b5cd36c15224b59e8bb451c90&el=desc) will **decrease** coverage by `54.30%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/10209/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10209 +/- ##
===========================================
- Coverage 89.41% 35.11% -54.31%
===========================================
Files 1037 1037
Lines 50011 50011
===========================================
- Hits 44717 17560 -27157
- Misses 5294 32451 +27157
```
| Flag | Coverage Δ | |
|---|---|---|
| #kubernetes-tests-3.6-9.6 | `?` | |
| #kubernetes-tests-image-3.6-v1.16.9 | `?` | |
| #kubernetes-tests-image-3.6-v1.17.5 | `?` | |
| #kubernetes-tests-image-3.6-v1.18.6 | `?` | |
| #kubernetes-tests-image-3.7-v1.16.9 | `?` | |
| #kubernetes-tests-image-3.7-v1.17.5 | `?` | |
| #kubernetes-tests-image-3.7-v1.18.6 | `?` | |
| #mysql-tests-Core-3.7-5.7 | `?` | |
| #mysql-tests-Core-3.8-5.7 | `?` | |
| #mysql-tests-Integration-3.7-5.7 | `34.75% <ø> (ø)` | |
| #mysql-tests-Integration-3.8-5.7 | `?` | |
| #postgres-tests-Core-3.6-10 | `?` | |
| #postgres-tests-Core-3.6-9.6 | `?` | |
| #postgres-tests-Core-3.7-10 | `?` | |
| #postgres-tests-Core-3.7-9.6 | `?` | |
| #postgres-tests-Integration-3.6-10 | `?` | |
| #postgres-tests-Integration-3.6-9.6 | `?` | |
| #postgres-tests-Integration-3.7-10 | `?` | |
| #postgres-tests-Integration-3.7-9.6 | `34.73% <ø> (ø)` | |
| #sqlite-tests-Core-3.6 | `?` | |
| #sqlite-tests-Core-3.8 | `?` | |
| #sqlite-tests-Integration-3.6 | `34.18% <ø> (ø)` | |
| #sqlite-tests-Integration-3.8 | `34.44% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/contrib/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL19faW5pdF9fLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [905 more](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=footer). Last update [d79e722...a0dec32](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-commenter edited a comment on pull request #10209: You can now trigger apache/airflow sync via Github Web UI
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10209:
URL: https://github.com/apache/airflow/pull/10209#issuecomment-670219050
# [Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=h1) Report
> Merging [#10209](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d79e7221de76f01b5cd36c15224b59e8bb451c90&el=desc) will **decrease** coverage by `54.30%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/10209/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10209 +/- ##
===========================================
- Coverage 89.41% 35.11% -54.31%
===========================================
Files 1037 1037
Lines 50011 50011
===========================================
- Hits 44717 17560 -27157
- Misses 5294 32451 +27157
```
| Flag | Coverage Δ | |
|---|---|---|
| #kubernetes-tests-3.6-9.6 | `?` | |
| #kubernetes-tests-image-3.6-v1.16.9 | `?` | |
| #kubernetes-tests-image-3.6-v1.17.5 | `?` | |
| #kubernetes-tests-image-3.6-v1.18.6 | `?` | |
| #kubernetes-tests-image-3.7-v1.16.9 | `?` | |
| #kubernetes-tests-image-3.7-v1.17.5 | `?` | |
| #kubernetes-tests-image-3.7-v1.18.6 | `?` | |
| #mysql-tests-Core-3.7-5.7 | `?` | |
| #mysql-tests-Core-3.8-5.7 | `?` | |
| #mysql-tests-Integration-3.7-5.7 | `34.75% <ø> (ø)` | |
| #mysql-tests-Integration-3.8-5.7 | `?` | |
| #postgres-tests-Core-3.6-10 | `?` | |
| #postgres-tests-Core-3.6-9.6 | `?` | |
| #postgres-tests-Core-3.7-10 | `?` | |
| #postgres-tests-Core-3.7-9.6 | `?` | |
| #postgres-tests-Integration-3.6-10 | `34.73% <ø> (ø)` | |
| #postgres-tests-Integration-3.6-9.6 | `?` | |
| #postgres-tests-Integration-3.7-10 | `34.73% <ø> (ø)` | |
| #postgres-tests-Integration-3.7-9.6 | `34.73% <ø> (ø)` | |
| #sqlite-tests-Core-3.6 | `?` | |
| #sqlite-tests-Core-3.8 | `?` | |
| #sqlite-tests-Integration-3.6 | `34.18% <ø> (ø)` | |
| #sqlite-tests-Integration-3.8 | `34.44% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/contrib/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL19faW5pdF9fLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [905 more](https://codecov.io/gh/apache/airflow/pull/10209/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=footer). Last update [d79e722...a0dec32](https://codecov.io/gh/apache/airflow/pull/10209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org