You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/10/02 23:10:20 UTC
[GitHub] [geode] PurelyApplied opened pull request #2558: GEODE-5803:
Remove geode-core:integrationTest dependency on *:test:output
Move many classes that are required as test source input from `geode-core:test` to `geode-junit:main`
-----
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2558 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #2558: GEODE-5803:
Remove geode-core:integrationTest dependency on *:test:output
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
This most recent commit is acknowledged as overkill. I just want to confirm or deny whether or not there would be any `*core:test` failures with resources moved this way. This is more to expose any other possible failures than I necessarily believe this is where all these resources belong.
[ Full content available at: https://github.com/apache/geode/pull/2558 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #2558: GEODE-5803:
Remove geode-core:integrationTest dependency on *:test:output
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Shifting resources wasn't as robust as I had hoped. Closing for now.
[ Full content available at: https://github.com/apache/geode/pull/2558 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied closed pull request #2558: GEODE-5803:
Remove geode-core:integrationTest dependency on *:test:output
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2558 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org