You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2026/07/30 08:42:50 UTC

[PR] Run CI on airflow-ctl release-branch pull requests and pushes [airflow]

Lee-W opened a new pull request, #70724:
URL: https://github.com/apache/airflow/pull/70724

   Pull requests targeting this branch received no CI at all: the airflow-ctl release-branch patterns were missing from the workflow trigger filters, so only branch-independent bot checks reported and a PR could show all-green without any tests or CodeQL ever running.
   
   GitHub resolves trigger filters from the workflow files on the target branch, so the equivalent fix on main (#69626) does not apply here and has to land on the release branch itself.
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [x] Yes (please specify the tool below)
   
   Generated-by: [Claude] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Run CI on airflow-ctl release-branch pull requests and pushes [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #70724:
URL: https://github.com/apache/airflow/pull/70724#issuecomment-6394255296

   Ah right... org policy ash mentioned in the mailing list. A bit busy this weekend. Will do it tonight when I get back home!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Run CI on airflow-ctl release-branch pull requests and pushes [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #70724:
URL: https://github.com/apache/airflow/pull/70724


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Run CI on airflow-ctl release-branch pull requests and pushes [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #70724:
URL: https://github.com/apache/airflow/pull/70724#issuecomment-6393511279

   @Lee-W Created a [patch ](https://github.com/shahar1/airflow/commit/c79b51488e6c2a29ebae9863de4bb949b3c06a02), so you could quickly merge into your PR and merge to main (I can't push commits to it directly):
   `git pull git@github.com:shahar1/airflow.git ci-trigger-airflow-ctl-v0-1-test && git push --force-with-lease`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Run CI on airflow-ctl release-branch pull requests and pushes [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #70724:
URL: https://github.com/apache/airflow/pull/70724#discussion_r4368409386


##########
.github/workflows/ci-amd-arm.yml:
##########
@@ -24,12 +24,18 @@ on:  # yamllint disable-line rule:truthy
     branches:
       - v[0-9]+-[0-9]+-test
       - providers-[a-z]+-?[a-z]*/v[0-9]+-[0-9]+
+      - chart/v[0-9]+-[0-9]+x-test
+      - airflow-ctl/v[0-9]+-[0-9]+-test
   pull_request:
     branches:
       - main
       - v[0-9]+-[0-9]+-test
       - v[0-9]+-[0-9]+-stable
       - providers-[a-z]+-?[a-z]*/v[0-9]+-[0-9]+
+      - chart/v[0-9]+-[0-9]+x-test
+      - chart/v[0-9]+-[0-9]+x-stable
+      - airflow-ctl/v[0-9]+-[0-9]+-test
+      - airflow-ctl/v[0-9]+-[0-9]+-stable

Review Comment:
   **major** — the premise has moved since this was written. #75555 (merged into `airflow-ctl/v0-1-test` today) added a dedicated `airflow-ctl-tests.yml` that already runs on pull requests to `airflow-ctl/v*-test` and `airflow-ctl/v*-stable`, plus the `CI passed` gate the release-branch ruleset requires. Its `ci-passed` job needs only `tests-airflow-ctl`.
   
   With this change on top, every PR to this branch would also start the full `Tests (AMD/ARM)` workflow. On this PR's head that workflow is red (Static checks, PROD image 3.10), and it is not part of `CI passed`, so it would neither block nor gate auto-merge — it would just show a red X on every backport.
   
   Could you rebase on #75555 and decide which of the two is wanted here? Either drop the `ci-amd-arm.yml` trigger changes and keep only CodeQL, or make the full workflow green on this branch and add it to the gate (the `check-ci-gate-needs` hook would then need to know about it).



##########
airflow-ctl-tests/tests/airflowctl_tests/test_airflowctl_commands.py:
##########
@@ -140,6 +134,19 @@ def date_param():
     "plugins list-import-errors",
 ]
 
+# TODO: remove the skip once core exposes the asset state store API (the 3.2.x core does not).

Review Comment:
   **minor** — this branch is anchored on core 3.2.1 and will not gain the asset state-store API, so the condition in this TODO (and in the `asset_state_store.py` docstring, "Once core provides the API, move them back into `generated.py`") can never be met here. The practical effect is that the six commands backported in #72742 ship in 0.1.x with no integration coverage at all.
   
   The skip is a reasonable way to unblock CI, but it hides a release question rather than answering it: should these commands be in a 0.1.x patch release that only targets 3.2.x servers, or should #72742 be reverted from `airflow-ctl/v0-1-test`? If they stay, I would reword the TODO to say they stay skipped for the life of this branch, so nobody waits for a core change that will not come.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org