You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/07 08:25:43 UTC

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #14083: Pulsar IO: implement --retain-key-ordering (KEY_SHARED subscription) for Sinks

Anonymitaet edited a comment on pull request #14083:
URL: https://github.com/apache/pulsar/pull/14083#issuecomment-1031192566


   Hi @eolivelli for the doc side, the parameter explanation has been added to code files and shown on the pulsar-admin page (https://pulsar.apache.org/tools/pulsar-admin/2.10.0-SNAPSHOT/#sinks)
   
   ![image](https://user-images.githubusercontent.com/50226895/152750835-7a8c5e93-964e-4167-a85d-e6d1a0621e3f.png)
   
   But this PR is still labeled w/ `doc-required`, do we need to explain/highlight it to Pulsar documentation?
   - If yes, can you update docs?
   - If no, can you label this PR w/ `doc` since it already contains doc changes, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org