[GitHub] [cassandra] aweisberg commented on a diff in pull request #2237: CASSANDRA-18129 Accord <-> Paxos live migration

["aweisberg (via GitHub)" <gi...@apache.org>]

aweisberg commented on code in PR #2237:
URL: https://github.com/apache/cassandra/pull/2237#discussion_r1231538320


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -2957,6 +2974,10 @@ public static boolean paxoTopologyRepairStrictEachQuorum()
         return conf.paxos_topology_repair_strict_each_quorum;
     }
 
+    // TODO imperative that at startup we check that the legacy paxos strategy is compatible
+    // with cluster metadata for consensus migration
+    // If another node updates the CM with consensus migration and we don't support it that is a serious issue as well
+    // Ideally this config could only ever exist in CM so that the cluster always agrees on what it is

Review Comment:
   This PR is out of date now that I have a new rebased branch elsewhere. Just FYI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org