[GitHub] [beam] ibzib commented on a change in pull request #14049: [BEAM-10961] enable strict dependency checking for sdks/java/io/contextualtextio

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #14049:
URL: https://github.com/apache/beam/pull/14049#discussion_r581566390



##########
File path: sdks/java/io/contextualtextio/build.gradle
##########
@@ -18,18 +18,22 @@
 
 plugins { id 'org.apache.beam.module' }
 applyJavaNature(
+        enableStrictDependencies:true,

Review comment:
       nit: spacing
   ```suggestion
           enableStrictDependencies: true,
   ```

##########
File path: sdks/java/io/contextualtextio/build.gradle
##########
@@ -18,18 +18,22 @@
 
 plugins { id 'org.apache.beam.module' }
 applyJavaNature(
+        enableStrictDependencies:true,
         automaticModuleName: 'org.apache.beam.sdk.io.contextualtextio',
 )
 
 description = "Apache Beam :: SDKs :: Java :: Contextual-Text-IO"
 ext.summary = "Context-aware Text IO."
 
 dependencies {
-    compile library.java.vendored_guava_26_0_jre
-    compile library.java.protobuf_java
     compile project(path: ":sdks:java:core", configuration: "shadow")
-    testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
+    compile library.java.protobuf_java
+    permitUnusedDeclared library.java.protobuf_java

Review comment:
       Link to the JIRA here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org