[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2154: 18252 trunk 4

["michaelsembwever (via GitHub)" <gi...@apache.org>]

michaelsembwever commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103165489


##########
src/java/org/apache/cassandra/cql3/functions/UDFunction.java:
##########
@@ -266,13 +266,7 @@ public static UDFunction create(FunctionName name,
     {
         assertUdfsEnabled(language);
 
-        switch (language)
-        {
-            case "java":
-                return new JavaBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, body);
-            default:
-                return new ScriptBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, language, body);

Review Comment:
   should the `src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java` file also be deleted? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org