[GitHub] [maven-release] michael-o commented on a change in pull request #62: [MRELEASE-899] Feature/lineseparator

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #62:
URL: https://github.com/apache/maven-release/pull/62#discussion_r808368072



##########
File path: maven-release-manager/src/main/mdo/release-descriptor.mdo
##########
@@ -604,6 +604,16 @@
           </description>
         </field>
 
+        <field>
+          <name>lineSeparator</name>
+          <version>3.0.0+</version>
+          <type>String</type>
+          <description>
+            Specifies the line separator to use in the pom.xml.
+            (https://issues.apache.org/jira/browse/MRELEASE-899)

Review comment:
       Redundant

##########
File path: maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java
##########
@@ -567,6 +567,15 @@
      */
     String getAutoResolveSnapshots();
 
+    /**
+     * Get the line separator to use in the pom.xml.
+     *
+     * (https://issues.apache.org/jira/browse/MRELEASE-899).

Review comment:
       This is reduandant since it is in the commit message and blame.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org