You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/08/09 01:14:24 UTC

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20335


Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection
......................................................................

[clock] fix HybridClockTest.TimeSourceAutoSelection

It was reported that HybridClockTest.TimeSourceAutoSelection scenario
had failed with the following message:

  src/kudu/clock/hybrid_clock-test.cc:501: Failure
  Value of: s.ToString()
  Expected: has substring "Error reading clock. Clock considered unsynchronized"
  Actual: "Service unavailable: timed out waiting for clock synchronisation: wallclock is not synchronized: no valid NTP responses yet" (of type std::string)

This patch addresses the issue, updating the pattern of the expected
error message to account for the string output by the built-in NTP
clock as well.

Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd
Reviewed-on: http://gerrit.cloudera.org:8080/20324
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Yifan Zhang <ch...@163.com>
(cherry picked from commit ebf0a645d5deb4be40faf441e230be07016fb683)
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 9 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/20335/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd
Gerrit-Change-Number: 20335
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20335 )

Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection
......................................................................

[clock] fix HybridClockTest.TimeSourceAutoSelection

It was reported that HybridClockTest.TimeSourceAutoSelection scenario
had failed with the following message:

  src/kudu/clock/hybrid_clock-test.cc:501: Failure
  Value of: s.ToString()
  Expected: has substring "Error reading clock. Clock considered unsynchronized"
  Actual: "Service unavailable: timed out waiting for clock synchronisation: wallclock is not synchronized: no valid NTP responses yet" (of type std::string)

This patch addresses the issue, updating the pattern of the expected
error message to account for the string output by the built-in NTP
clock as well.

Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd
Reviewed-on: http://gerrit.cloudera.org:8080/20324
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Yifan Zhang <ch...@163.com>
(cherry picked from commit ebf0a645d5deb4be40faf441e230be07016fb683)
Reviewed-on: http://gerrit.cloudera.org:8080/20335
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
  Yifan Zhang: Looks good to me, approved
  Yingchun Lai: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd
Gerrit-Change-Number: 20335
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/20335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd
Gerrit-Change-Number: 20335
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20335 )

Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd
Gerrit-Change-Number: 20335
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 09 Aug 2023 01:45:19 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20335 )

Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie30ca383f50db1f62e140da5181e9a406367f7bd
Gerrit-Change-Number: 20335
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 09 Aug 2023 02:46:03 +0000
Gerrit-HasComments: No