You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/09/14 20:43:47 UTC
[GitHub] [pinot] walterddr opened a new issue, #11593: Query response code/content is confusing
walterddr opened a new issue, #11593:
URL: https://github.com/apache/pinot/issues/11593
we have 2 query endpoints: `<controller_hostport>/sql` and `<broker_hostport>/query/sql`
when querying with proper queries they return the same results. however when there's an error.
Controller returns different format of error comparing to broker
- Controller error for `SELECT * FROM tbl LIMIMIMIT 1`:
HTTP code: 200; content: RAW STRING `SQLParsingError:\norg.apache.pinot.s .....`
- Broker error for `SELECT * FROM tbl LIMIMIMIT 1`:
HTTP code: 200; content: JSON STRONG `{"requestId":null,"brokerId":null,"exceptions":[{"message":"SQLParsingError:\norg.apache.pinot.s...`
we should follow a single format. I propose to use JSON b/c both HTTP codes are return 200 indicating a valid request
backward incompatible, we will change the response content of a REST API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #11593: Query response code/content is confusing
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #11593:
URL: https://github.com/apache/pinot/issues/11593#issuecomment-1722559914
+1. We should at least return a valid JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr closed issue #11593: Query response code/content is confusing
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr closed issue #11593: Query response code/content is confusing
URL: https://github.com/apache/pinot/issues/11593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org