[kudu-CR] Replace BOOST_FOREACH with c++11 range syntax

["Dan Burkert (Code Review)" <ge...@ip-10-146-233-104.ec2.internal>]

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1786

to review the following change.

Change subject: Replace BOOST_FOREACH with c++11 range syntax
......................................................................

Replace BOOST_FOREACH with c++11 range syntax

This was created using some scripts that Mike put together, along with some
manual tweaks.

Change-Id: I635ba6e83b65eec4427c10175c203c4864b2a22f
---
M docs/contributing.adoc
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/benchmarks/wal_hiccup.cc
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client-internal.cc
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/schema.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_creator-internal.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/codegen/row_projector.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/predicate_encoder.cc
M src/kudu/common/rowblock.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol.cc
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/local_consensus.cc
M src/kudu/consensus/log-dump.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_anchor_registry.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_index.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/consensus/raft_consensus_state-test.cc
M src/kudu/consensus/raft_consensus_state.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/fs/block_id.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-test-util.h
M src/kudu/master/master-test.cc
M src/kudu/master/master.cc
M src/kudu/master/master_rpc.cc
M src/kudu/master/master_service.cc
M src/kudu/master/mini_master.cc
M src/kudu/master/sys_catalog-test.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_manager.cc
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/rpc-bench.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/sasl_client.cc
M src/kudu/rpc/sasl_helper.cc
M src/kudu/rpc/sasl_server.cc
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/transfer.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/rpc_server.cc
M src/kudu/server/server_base.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webui_util.cc
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_iterator_merger.cc
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/maintenance_manager.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/mt-diskrowset-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/multi_column_writer.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/tablet/tablet_peer.cc
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tablet/transactions/transaction_tracker-test.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tools/fs_dump-tool.cc
M src/kudu/tools/fs_list-tool.cc
M src/kudu/tools/fs_tool.cc
M src/kudu/tools/insert-generated-rows.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-admin.cc
M src/kudu/tools/kudu-ksck.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/ts-cli.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_service-test.cc
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/remote_bootstrap_session.cc
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/oauth.cc
M src/kudu/twitter-demo/parser-test.cc
M src/kudu/util/atomic-test.cc
M src/kudu/util/blocking_queue.h
M src/kudu/util/cache.cc
M src/kudu/util/debug-util-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/failure_detector.cc
M src/kudu/util/flags.cc
M src/kudu/util/interval_tree-inl.h
M src/kudu/util/interval_tree-test.cc
M src/kudu/util/interval_tree.h
M src/kudu/util/jsonreader-test.cc
M src/kudu/util/jsonwriter.cc
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/knapsack_solver-test.cc
M src/kudu/util/knapsack_solver.h
M src/kudu/util/mem_tracker-test.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/memcmpable_varint-test.cc
M src/kudu/util/memenv/memenv-test.cc
M src/kudu/util/memenv/memenv.cc
M src/kudu/util/memory/arena-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/mt-metrics-test.cc
M src/kudu/util/mt-threadlocal-test.cc
M src/kudu/util/net/dns_resolver-test.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/nvm_cache.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/rolling_log-test.cc
M src/kudu/util/rw_semaphore-test.cc
M src/kudu/util/rwc_lock-test.cc
M src/kudu/util/slice-test.cc
M src/kudu/util/striped64-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/sync_point.cc
M src/kudu/util/test_graph.cc
M src/kudu/util/thread.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/trace-test.cc
M src/kudu/util/trace.cc
M src/kudu/util/url-coding.cc
255 files changed, 943 insertions(+), 1,120 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/1786/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I635ba6e83b65eec4427c10175c203c4864b2a22f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>