You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/24 12:06:14 UTC

[GitHub] pnowojski commented on a change in pull request #6908: [FLINK-10220][e2e] Removing logs for streaming sql e2e test before validation

pnowojski commented on a change in pull request #6908: [FLINK-10220][e2e] Removing logs for streaming sql e2e test before validation
URL: https://github.com/apache/flink/pull/6908#discussion_r227758726
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -300,7 +300,7 @@ function start_and_wait_for_tm {
 }
 
 function check_logs_for_errors {
-  if grep -rv "GroupCoordinatorNotAvailableException" $FLINK_DIR/log \
+  error_count=$(grep -rv "GroupCoordinatorNotAvailableException" $FLINK_DIR/log \
 
 Review comment:
   Please add the description to the commit message why this change was needed. Maybe a bit extended description from the PR?
   
   Btw, is this a hotfix and it doesn't have Jira ticket?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services