You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tragicjun <gi...@git.apache.org> on 2018/05/16 16:28:29 UTC
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
GitHub user tragicjun opened a pull request:
https://github.com/apache/flink/pull/6026
[FLINK-9384]KafkaAvroTableSource failed to work due to type mismatch
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tragicjun/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6026.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6026
----
commit 802e7e211b7bea6fd17b88a058591272f0fb215f
Author: jerryjzhang <zh...@...>
Date: 2018-05-16T16:27:32Z
[FLINK-9384]KafkaAvroTableSource failed to work due to type mismatch
----
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r189437091
--- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java ---
@@ -110,6 +116,8 @@ private void writeObject(ObjectOutputStream oos) throws IOException {
oos.writeObject(recordClazz);
}
+
--- End diff --
nice catch.
---
[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
@twalthr sure, just a second, I never did this before, let me try
---
[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
Thanks @suez1224 for reviewing. I've committed a new patch as per your suggestions. As for the unit test, the issue was exposed in my integration tests which requires a kafka setup, any advice on how it could be done in unit tests?
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6026
---
[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6026
@tragicjun this PR is hard to merge with 6 commits and a merge branch in the middle. Can you squash your commits into one commit that is rebased on the current master and do a force push?
---
[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6026
Thank you @tragicjun. LGTM. Merging...
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r190169511
--- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java ---
@@ -76,19 +77,35 @@
*/
private SpecificRecord record;
+ /** Type information describing the result type.
+ *
+ */
+ private final TypeInformation<Row> typeInfo;
--- End diff --
Declare this transient?
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r190169591
--- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java ---
@@ -76,19 +77,35 @@
*/
private SpecificRecord record;
+ /** Type information describing the result type.
--- End diff --
Put the text one line down.
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r190170050
--- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java ---
@@ -76,19 +77,35 @@
*/
private SpecificRecord record;
+ /** Type information describing the result type.
+ *
+ */
+ private final TypeInformation<Row> typeInfo;
+
/**
* Creates a Avro deserialization schema for the given record.
*
* @param recordClazz Avro record class used to deserialize Avro's record to Flink's row
*/
- public AvroRowDeserializationSchema(Class<? extends SpecificRecord> recordClazz) {
+ public AvroRowDeserializationSchema(Class<? extends SpecificRecord> recordClazz){
+ this(recordClazz, null);
+ }
+
+ /**
+ * Creates a Avro deserialization schema for the given record.
+ *
+ * @param recordClazz Avro record class used to deserialize Avro's record to Flink's row
+ * @param typeInfo Type information describing the result type.
+ */
+ public AvroRowDeserializationSchema(Class<? extends SpecificRecord> recordClazz, TypeInformation<Row> typeInfo) {
--- End diff --
This constructor is not required. We should always use the result of the `AvroRecordClassConverter`.
---
[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
@twalthr Thanks for the comment. I've commited a new version as per your suggestion. Particularly, I agree that TypeInfomation should always be derived from the 'avroRecrodClass', but the constructor of AvroRowDeserializationSchema only takes argument as type 'Class<? extends SpecificRecord>'. In this version I've changed the argument as 'Class<? extends SpecificRecordBase>' and fixed relevant test cases accordingly. This version of fix has passed relevant unit tests and my local integration tests.
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r188786194
--- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSource.java ---
@@ -81,7 +85,12 @@ public String explainSource() {
@Override
protected AvroRowDeserializationSchema getDeserializationSchema() {
- return new AvroRowDeserializationSchema(avroRecordClass);
+ return new AvroRowDeserializationSchema(avroRecordClass, tableSchemaToReturnType(schema));
+ }
+
+ /** Converts the table schema into into the return type. */
+ private static RowTypeInfo tableSchemaToReturnType(TableSchema tableSchema) {
--- End diff --
Do you need this extra function, I think just inlining it should be fine.
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r189437087
--- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSource.java ---
@@ -81,7 +85,12 @@ public String explainSource() {
@Override
protected AvroRowDeserializationSchema getDeserializationSchema() {
- return new AvroRowDeserializationSchema(avroRecordClass);
+ return new AvroRowDeserializationSchema(avroRecordClass, tableSchemaToReturnType(schema));
+ }
+
+ /** Converts the table schema into into the return type. */
+ private static RowTypeInfo tableSchemaToReturnType(TableSchema tableSchema) {
--- End diff --
Extra function has been removed.
---
[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r188786307
--- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java ---
@@ -110,6 +116,8 @@ private void writeObject(ObjectOutputStream oos) throws IOException {
oos.writeObject(recordClazz);
}
+
--- End diff --
extra blank line here.
---
[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
@twalthr the latest commit could be merged which contains all the changes.
---
[GitHub] flink issue #6026: [FLINK-9384]KafkaAvroTableSource failed to work due to ty...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
Hi @suez1224, I've added some checks in the unit tests(KafkaAvroTableSourceTestBase), which would fail before the fix. Meanwhile, I found an issue in the previous version (specifically, the produced type info should be inferred from AvroRecordClass not TableSchema), which has been fixed. Would you please take a review?
---