You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/11/09 07:05:04 UTC

[GitHub] [servicecomb-java-chassis] fanjiwang1992 opened a new pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

fanjiwang1992 opened a new pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635


    fix the compatibility with spring 5.3.7 or later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-963884002


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2635](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebf2f8b) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/eacfbf6dd6f12671d044e884743ab4bb1607e324?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eacfbf6) will **decrease** coverage by `0.02%`.
   > The diff coverage is `48.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2635      +/-   ##
   ============================================
   - Coverage     77.74%   77.71%   -0.03%     
     Complexity     1429     1429              
   ============================================
     Files          1598     1598              
     Lines         42657    42698      +41     
     Branches       3592     3601       +9     
   ============================================
   + Hits          33162    33182      +20     
   - Misses         7996     8011      +15     
   - Partials       1499     1505       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...der/springmvc/reference/CseUriTemplateHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXNwcmluZ212Yy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcHJvdmlkZXIvc3ByaW5nbXZjL3JlZmVyZW5jZS9Dc2VVcmlUZW1wbGF0ZUhhbmRsZXIuamF2YQ==) | `66.17% <48.78%> (-26.42%)` | :arrow_down: |
   | [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `94.44% <0.00%> (-5.56%)` | :arrow_down: |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `86.66% <0.00%> (+3.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eacfbf6...ebf2f8b](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 edited a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969980638


   @fanjiwang1992  @pigbayspy 
   
   1. `StringUtils` 可以统一使用 commons-lang 的接口，不要使用 Spring 的类。 我记得前期已经做过大量修改， 可能有些遗漏。
   
   2.  `cse://app:ms/path ` 问题，可以参考这里的讨论和处理措施： https://github.com/apache/servicecomb-java-chassis/issues/2631
   3. 提交PR前可以尝试执行 `mvn clean install -Pid` 本地验证下，节省时间。 （需要本地启动一下service center。 本方面不会运行demo目录下面的自动化测试用例，运行demo目录下面的测试用例需要docker环境，详细可以参考github构建配置，在.github目录）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 edited a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969980638


   @fanjiwang1992  @pigbayspy 
   
   1. `StringUtils` 可以统一使用 commons-lang 的接口，不要使用 Spring 的类。 我记得前期已经做过大量修改， 可能有些遗漏。
   
   2.  `cse://app:ms/path ` 问题，可以参考这里的讨论和处理措施： https://github.com/apache/servicecomb-java-chassis/issues/2631
   3. 提交PR前可以尝试执行 `mvn clean install -Pid` 本地验证下，节省时间。 （需要本地启动一下service center。 本方法不会运行demo目录下面的自动化测试用例，运行demo目录下面的测试用例需要docker环境，详细可以参考github构建配置，在.github目录）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] pigbayspy commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
pigbayspy commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969975839


   然后还有两个问题
   
   - 测试代码中 ConfigFileApplicationContextInitializer 这个类已过时，可以用 ConfigFileApplicationContextInitializer 这个类代替
   - 针对 CseUriTemplateHandler 这个类的测试会失败，因为其不支持 cse://app:ms/path 这一类 url，不知道是不是因为升级 spring 引起的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] fanjiwang1992 closed pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
fanjiwang1992 closed pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] pigbayspy commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
pigbayspy commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-967078152


   > > > > servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？
   > > > 
   > > > 
   > > > @liubao68 当前只是处理了兼容问题 是否升级一下spring以及spring boot的版本
   > > 
   > > 
   > > 最好能及时跟进最新的 spring 的版本，因为 5.2.9 的 spring framework 存在很多 CVE 漏洞
   > 
   > 我觉得可以升级spring和spring boot
   
   可以升级到 5.3.12 版本的 spring framework 和 2.5.6 的 spring boot，我可以试试


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969980638


   @fanjiwang1992  @pigbayspy 
   
   1. `StringUtils` 可以统一使用 commons-lang 的接口，不要使用 Spring 的类。 我记得前期已经做过大量修改， 可能有些遗漏。
   
   2.  `cse://app:ms/path ` 问题，可以参考这里的讨论和处理措施： https://github.com/apache/servicecomb-java-chassis/issues/2631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] fanjiwang1992 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
fanjiwang1992 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-967788363


   > > > > > servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？
   > > > > 
   > > > > 
   > > > > @liubao68 当前只是处理了兼容问题 是否升级一下spring以及spring boot的版本
   > > > 
   > > > 
   > > > 最好能及时跟进最新的 spring 的版本，因为 5.2.9 的 spring framework 存在很多 CVE 漏洞
   > > 
   > > 
   > > 我觉得可以升级spring和spring boot
   > 
   > 可以升级到 5.3.12 版本的 spring framework 和 2.5.6 的 spring boot，我可以试试
   
   可以的 你可以在我的这个分支上提交一下


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] fanjiwang1992 removed a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
fanjiwang1992 removed a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-967788363


   > > > > > servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？
   > > > > 
   > > > > 
   > > > > @liubao68 当前只是处理了兼容问题 是否升级一下spring以及spring boot的版本
   > > > 
   > > > 
   > > > 最好能及时跟进最新的 spring 的版本，因为 5.2.9 的 spring framework 存在很多 CVE 漏洞
   > > 
   > > 
   > > 我觉得可以升级spring和spring boot
   > 
   > 可以升级到 5.3.12 版本的 spring framework 和 2.5.6 的 spring boot，我可以试试
   
   可以的 你可以在我的这个分支上提交一下


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] fanjiwang1992 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
fanjiwang1992 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969962415


   > 我昨天看了一下升级要做的改动 @fanjiwang1992
   > 
   > * spring 提供的 StringUtils 的 isEmpty 方法被标记为弃用
   > * 我建议 servicecomb 自己编写一个 StringUtils 工具类，来提供 isEmptyString 和 isNotEmptyString 方法
   > * 同时，servicecomb 代码中有一些 片段如 `!StringUtils.isEmpty()` , 可以用 `StringUtils.isNotEmptyString()` 代替
   好的 收到 感谢


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] pigbayspy commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
pigbayspy commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969943946


   我昨天看了一下升级要做的改动 @fanjiwang1992 
   - spring 提供的 StringUtils 的 isEmpty 方法被标记为弃用
   - 我建议 servicecomb 自己编写一个 StringUtils 工具类，来提供 isEmptyString 和 isNotEmptyString 方法


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] pigbayspy edited a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
pigbayspy edited a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969943946


   我昨天看了一下升级要做的改动 @fanjiwang1992 
   - spring 提供的 StringUtils 的 isEmpty 方法被标记为弃用
   - 我建议 servicecomb 自己编写一个 StringUtils 工具类，来提供 isEmptyString 和 isNotEmptyString 方法
   - 同时，servicecomb 代码中有一些 片段如 `!StringUtils.isEmpty()` , 可以用 `StringUtils.isNotEmptyString()` 代替


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] fanjiwang1992 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
fanjiwang1992 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-966008942


   > servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？
   
   @liubao68 当前只是处理了兼容问题 是否升级一下spring以及spring boot的版本


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-968700755


   https://issues.apache.org/jira/projects/SCB/versions/12350513  根据版本计划， 本月底会有版本。 @fanjiwang1992  升级Spring，包括这个PR，能在这个时间前完成吗？发版本预计会要1周的准备时间（投票等）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] pigbayspy commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
pigbayspy commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-964918735


   servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 edited a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969980638


   @fanjiwang1992  @pigbayspy 
   
   1. `StringUtils` 可以统一使用 commons-lang 的接口，不要使用 Spring 的类。 我记得前期已经做过大量修改， 可能有些遗漏。
   
   2.  `cse://app:ms/path ` 问题，可以参考这里的讨论和处理措施： https://github.com/apache/servicecomb-java-chassis/issues/2631
   3. 提交PR前可以尝试执行 `mvn clean install -Pit` 本地验证下，节省时间。 （需要本地启动一下service center。 本方法会运行单元测试用例，和intergration-tests下面的用例， 但不会运行demo目录下面的自动化测试用例，运行demo目录下面的测试用例需要docker环境，详细可以参考github构建配置，在.github目录）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 edited a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969980638


   @fanjiwang1992  @pigbayspy 
   
   1. `StringUtils` 可以统一使用 commons-lang 的接口，不要使用 Spring 的类。 我记得前期已经做过大量修改， 可能有些遗漏。
   
   2.  `cse://app:ms/path ` 问题，可以参考这里的讨论和处理措施： https://github.com/apache/servicecomb-java-chassis/issues/2631
   3. 提交PR前可以尝试执行 `mvn clean install -Pid` 本地验证下，节省时间。 （需要本地启动一下service center。 本方面不会允许demo目录下面的自动化测试用例，允许demo目录下面的测试用例需要docker环境，详细可以参考github构建配置，在.github目录）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-963884002


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2635](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecf5a8c) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/2c537f67eb259cf3b0493561f63878b073249393?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2c537f6) will **decrease** coverage by `0.02%`.
   > The diff coverage is `50.00%`.
   
   > :exclamation: Current head ecf5a8c differs from pull request most recent head 6901be2. Consider uploading reports for the commit 6901be2 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2635      +/-   ##
   ============================================
   - Coverage     77.71%   77.69%   -0.03%     
     Complexity     1429     1429              
   ============================================
     Files          1598     1598              
     Lines         42686    42727      +41     
     Branches       3593     3602       +9     
   ============================================
   + Hits          33174    33197      +23     
   - Misses         8012     8021       +9     
   - Partials       1500     1509       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/element/impl/ConfigurableDatetimeAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL0NvbmZpZ3VyYWJsZURhdGV0aW1lQWNjZXNzSXRlbS5qYXZh) | `94.73% <ø> (ø)` | |
   | [...core/element/impl/InvocationContextAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL0ludm9jYXRpb25Db250ZXh0QWNjZXNzSXRlbS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...Log/core/element/impl/RequestHeaderAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL1JlcXVlc3RIZWFkZXJBY2Nlc3NJdGVtLmphdmE=) | `89.47% <ø> (ø)` | |
   | [.../core/element/impl/UrlPathWithQueryAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL1VybFBhdGhXaXRoUXVlcnlBY2Nlc3NJdGVtLmphdmE=) | `100.00% <ø> (ø)` | |
   | [.../common/rest/codec/param/BodyProcessorCreator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9wYXJhbS9Cb2R5UHJvY2Vzc29yQ3JlYXRvci5qYXZh) | `81.91% <ø> (ø)` | |
   | [...cecomb/common/rest/locator/ServicePathManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9sb2NhdG9yL1NlcnZpY2VQYXRoTWFuYWdlci5qYXZh) | `98.18% <ø> (ø)` | |
   | [...rvicecomb/core/ConfigurationSpringInitializer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9Db25maWd1cmF0aW9uU3ByaW5nSW5pdGlhbGl6ZXIuamF2YQ==) | `76.33% <ø> (ø)` | |
   | [...in/java/org/apache/servicecomb/core/SCBEngine.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9TQ0JFbmdpbmUuamF2YQ==) | `81.74% <ø> (ø)` | |
   | [...rvicecomb/core/handler/AbstractHandlerManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9oYW5kbGVyL0Fic3RyYWN0SGFuZGxlck1hbmFnZXIuamF2YQ==) | `83.33% <ø> (ø)` | |
   | [...demo/jaxrs/client/MultiErrorCodeServiceClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvTXVsdGlFcnJvckNvZGVTZXJ2aWNlQ2xpZW50LmphdmE=) | `88.95% <ø> (ø)` | |
   | ... and [28 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2c537f6...6901be2](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] fanjiwang1992 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
fanjiwang1992 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-967788484


   > > > > > servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？
   > > > > 
   > > > > 
   > > > > @liubao68 当前只是处理了兼容问题 是否升级一下spring以及spring boot的版本
   > > > 
   > > > 
   > > > 最好能及时跟进最新的 spring 的版本，因为 5.2.9 的 spring framework 存在很多 CVE 漏洞
   > > 
   > > 
   > > 我觉得可以升级spring和spring boot
   > 
   > 可以升级到 5.3.12 版本的 spring framework 和 2.5.6 的 spring boot，我可以试试
   
   可以的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] kinkwok117 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
kinkwok117 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-968624338


   这个修改什么时候会有版本


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-963884002


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2635](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebf2f8b) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/eacfbf6dd6f12671d044e884743ab4bb1607e324?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eacfbf6) will **increase** coverage by `0.01%`.
   > The diff coverage is `48.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2635      +/-   ##
   ============================================
   + Coverage     77.74%   77.75%   +0.01%     
   - Complexity     1429     1430       +1     
   ============================================
     Files          1598     1598              
     Lines         42657    42822     +165     
     Branches       3592     3634      +42     
   ============================================
   + Hits          33162    33296     +134     
   - Misses         7996     8016      +20     
   - Partials       1499     1510      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...der/springmvc/reference/CseUriTemplateHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXNwcmluZ212Yy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcHJvdmlkZXIvc3ByaW5nbXZjL3JlZmVyZW5jZS9Dc2VVcmlUZW1wbGF0ZUhhbmRsZXIuamF2YQ==) | `66.17% <48.78%> (-26.42%)` | :arrow_down: |
   | [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `94.44% <0.00%> (-5.56%)` | :arrow_down: |
   | [...a/org/apache/servicecomb/swagger/SwaggerUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9Td2FnZ2VyVXRpbHMuamF2YQ==) | `92.57% <0.00%> (-0.90%)` | :arrow_down: |
   | [...cecomb/registry/consumer/MicroserviceVersions.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvY29uc3VtZXIvTWljcm9zZXJ2aWNlVmVyc2lvbnMuamF2YQ==) | `89.07% <0.00%> (+1.68%)` | :arrow_up: |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `86.66% <0.00%> (+3.33%)` | :arrow_up: |
   | [...xrs/client/validation/ValidationServiceClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvdmFsaWRhdGlvbi9WYWxpZGF0aW9uU2VydmljZUNsaWVudC5qYXZh) | `80.30% <0.00%> (+4.69%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eacfbf6...ebf2f8b](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2635?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-966963672


   > > > servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？
   > > 
   > > 
   > > @liubao68 当前只是处理了兼容问题 是否升级一下spring以及spring boot的版本
   > 
   > 最好能及时跟进最新的 spring 的版本，因为 5.2.9 的 spring framework 存在很多 CVE 漏洞
   
   我觉得可以升级spring和spring boot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] pigbayspy commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
pigbayspy commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-966239875


   > > servicecomb 依赖的是 5.2.9 的 Spring 版本，请问有没有升级 Spring 依赖到更高版本的计划呢？
   > 
   > @liubao68 当前只是处理了兼容问题 是否升级一下spring以及spring boot的版本
   
   最好能及时跟进最新的 spring 的版本，因为 5.2.9 的 spring framework 存在很多 CVE 漏洞


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] fanjiwang1992 commented on pull request #2635: [SCB-2356] fix the compatibility with spring 5.3.7 or later

Posted by GitBox <gi...@apache.org>.
fanjiwang1992 commented on pull request #2635:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2635#issuecomment-969962235


   > https://issues.apache.org/jira/projects/SCB/versions/12350513 根据版本计划， 本月底会有版本。 @fanjiwang1992 升级Spring，包括这个PR，能在这个时间前完成吗？发版本预计会要1周的准备时间（投票等）
   
   可以的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org