[jira] [Comment Edited] (SOLR-10011) Refactor PointField & TrieField to share common code

["Tomás Fernández Löbbe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840279#comment-15840279 ] 

Tomás Fernández Löbbe edited comment on SOLR-10011 at 1/26/17 7:38 PM:
-----------------------------------------------------------------------

[~ichattopadhyaya] as part of this refactor, what do you think about:
deprecating (and removing in master)
{code:title=FieldType.java}
  public LegacyNumericType getNumericType() {
    return null;
  }
{code}
and replacing it with
{code:title=FieldType.java}
 public NumericFieldType.NumberType getNumberType() {
    return null;
  }
{code}
...also replacing the newly added
{code:title=NumericFieldType.java}
  final public NumberType getType() {
    return type;
  }
{code}
with
{code:title=NumericFieldType.java}
  @Override
 final public NumericFieldType.NumberType getNumberType() {
    return type;
  }
{code}
That way clients don't need to cast to {{NumericFieldType}} for getting the actual type. Also, if we do it, we should probably move {{NumberType}} out of {{NumericFieldType}} and make it top level


was (Author: tomasflobbe):
[~ichattopadhyaya] As part of this refactor, what do you think about:
deprecating (and removing in master)
{code:title=FieldType.java}
  public LegacyNumericType getNumericType() {
    return null;
  }
{code}
and replacing it with
{code:title=FieldType.java}
 public NumericFieldType.NumberType getNumberType() {
    return null;
  }
{code}
...also replacing the newly added
{code:title=NumericFieldType.java}
  final public NumberType getType() {
    return type;
  }
{code}
with
{code:title=NumericFieldType.java}
  @Override
 final public NumericFieldType.NumberType getNumberType() {
    return type;
  }
{code}
That way clients don't need to cast to {{NumericFieldType}} for getting the actual type.

> Refactor PointField & TrieField to share common code
> ----------------------------------------------------
>
>                 Key: SOLR-10011
>                 URL: https://issues.apache.org/jira/browse/SOLR-10011
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Ishan Chattopadhyaya
>         Attachments: SOLR-10011.patch, SOLR-10011.patch, SOLR-10011.patch, SOLR-10011.patch
>
>
> We should eliminate PointTypes and TrieTypes enum to have a common enum for both. That would enable us to share a lot of code between the two field types.
> In the process, fix the bug:
> PointFields with indexed=false, docValues=true seem to be using (Int|Double|Float|Long)Point.newRangeQuery() for performing exact matches and range queries. However, they should instead be using DocValues based range query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org