[GitHub] [incubator-zipkin] tmichnik1981 commented on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree

[GitBox <gi...@apache.org>]

tmichnik1981 commented on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree 
URL: https://github.com/apache/incubator-zipkin/issues/2616#issuecomment-496517846
 
 
   Hi @adriancole ,
   
   Don't you think it is worth to present on the  dependency graph all the requests even within the same runtime? 
   I believe it is quite normal that developers may want to generate  spans to measure/visualize requests/responses between different components of the same application.
   
   For example someone might generate spans to profile/measure  the code flow connecting to some database. 
   It would be pretty valuable to see what happened  on the dependency graph.
   
   Assuming that, the dependency graph must be limited only  to RPC CLIENT --> SERVER calls, there 
   is still something wrong. 
   
   The condition which I mentioned above:
   
   ```
   if (Kind.CLIENT.equals(kind) && !current.children().isEmpty()) {
      continue;
   }
   ```
   omits relations between server and client as client component has some descendants.  
   
    component A ( SERVER) -->  component B  (CLIENT) --> SOME_OTHER_SPANS 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services