You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2012/12/05 23:01:05 UTC

Re: svn commit: r1417642 - in /subversion/trunk/subversion: include/svn_config.h libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_ra_serf/update.c libsvn_subr/config_file.c

On Wed, Dec 05, 2012 at 08:54:05PM -0000, lgo@apache.org wrote:
> Author: lgo
> Date: Wed Dec  5 20:54:03 2012
> New Revision: 1417642
> 
> URL: http://svn.apache.org/viewvc?rev=1417642&view=rev
> Log:
> Add a bulk-updates option to the global and per-server section in servers.
> This allows a user to disable the default skelta mode of ra_serf back to bulk
> update mode.
 
> Modified: subversion/trunk/subversion/libsvn_subr/config_file.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/config_file.c?rev=1417642&r1=1417641&r2=1417642&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_subr/config_file.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/config_file.c Wed Dec  5 20:54:03 2012
> @@ -807,6 +807,10 @@ svn_config_ensure(const char *config_dir
>          "###   http-library               Which library to use for http/https"
>                                                                               NL
>          "###                              connections."                      NL
> +        "###   bulk_updates               Whether to request bulk update" NL
> +        "###                              responses, or fetch each file in "
> +                                                                             NL
> +        "###                              an individual request. "           NL

I doubt anyone who isn't subscribed to dev@ will understand what
this option is doing.

Can you please extend this comment to explain to mortals what the
effect of turning bulk updates on or off is? Or at least link to
an existing document that explains this?

Also, the comment doesn't make clear that this option only pertains
to HTTP clients.

Re: svn commit: r1417642 - in /subversion/trunk/subversion: include/svn_config.h libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_ra_serf/update.c libsvn_subr/config_file.c

Posted by Lieven Govaerts <lg...@mobsol.be>.
Hi Peter,

On Fri, Dec 7, 2012 at 6:25 AM, Peter Samuelson <pe...@p12n.org> wrote:
>
>> >          "###   http-library               Which library to use for http/https"
>> >                                                                               NL
>> >          "###                              connections."                      NL
>> > +        "###   bulk_updates               Whether to request bulk update" NL
>> > +        "###                              responses, or fetch each file in "
>> > +                                                                             NL
>> > +        "###                              an individual request. "           NL
>
> [Stefan Sperling]
>> Can you please extend this comment to explain to mortals what the
>> effect of turning bulk updates on or off is? Or at least link to
>> an existing document that explains this?
>
> Also the option is spelled with "-", not "_".

That was fixed in a later commit.

Lieven

Re: svn commit: r1417642 - in /subversion/trunk/subversion: include/svn_config.h libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_ra_serf/update.c libsvn_subr/config_file.c

Posted by Peter Samuelson <pe...@p12n.org>.
> >          "###   http-library               Which library to use for http/https"
> >                                                                               NL
> >          "###                              connections."                      NL
> > +        "###   bulk_updates               Whether to request bulk update" NL
> > +        "###                              responses, or fetch each file in "
> > +                                                                             NL
> > +        "###                              an individual request. "           NL

[Stefan Sperling]
> Can you please extend this comment to explain to mortals what the
> effect of turning bulk updates on or off is? Or at least link to
> an existing document that explains this?

Also the option is spelled with "-", not "_".