You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "kbuci (via GitHub)" <gi...@apache.org> on 2025/12/16 00:47:10 UTC

[PR] [MINOR] Metadata write config should support specifying INLINE_COMPAC… [hudi]

kbuci opened a new pull request, #17603:
URL: https://github.com/apache/hudi/pull/17603

   …T_TIME_DELTA_SECONDS and INLINE_COMPACT_TRIGGER_STRATEGY
   
   ### Describe the issue this Pull Request addresses
   
    users should have a way to specify `compaction compact.inline.max.delta.seconds` and `compact.inline.trigger.strategy` for metadata table specifically
   
   
   ### Summary and Changelog
   
   Add configs `hoodie.metadata.compact.inline.trigger.strategy` and `hoodie.metadata.compact.inline.max.delta.seconds` , used when creating metadata table write config 
   ### Impact
   
   
   
   ### Risk Level
   
   none - default (data table) configs will continue to be used if not specified 
   
   ### Documentation Update
   
   <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3663276295

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 338f1e1c0902035ae94e55693268dbeecfb2151b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292) 
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * 5392700def3497a9c95ffad0db5a0dc2a7a262f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying INLINE_COMPAC… [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658223757

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * afc64bb82327fce36a3b5f9ccb578b11906c0069 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support MDT compaction configs of frequency seconds and trigger strategy [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #17603:
URL: https://github.com/apache/hudi/pull/17603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3663471555

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311",
       "triggerID" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * 5392700def3497a9c95ffad0db5a0dc2a7a262f4 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308) 
   * cf6cd8df9259f7e6269be89bbe95680de973d40f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3663592306

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311",
       "triggerID" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * cf6cd8df9259f7e6269be89bbe95680de973d40f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3663283538

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 338f1e1c0902035ae94e55693268dbeecfb2151b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292) 
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * 5392700def3497a9c95ffad0db5a0dc2a7a262f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308) 
   * cf6cd8df9259f7e6269be89bbe95680de973d40f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support MDT compaction configs of frequency seconds and trigger strategy [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3677096555

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311",
       "triggerID" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41567fe551118e22bd6a4cf14ffd3fed1dd200ca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "41567fe551118e22bd6a4cf14ffd3fed1dd200ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * cf6cd8df9259f7e6269be89bbe95680de973d40f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311) 
   * 41567fe551118e22bd6a4cf14ffd3fed1dd200ca UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3661686302

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3151b1a0ee450c482f6bf0e724cb6e95abdf168a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276) 
   * 338f1e1c0902035ae94e55693268dbeecfb2151b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3663270834

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 338f1e1c0902035ae94e55693268dbeecfb2151b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292) 
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * 5392700def3497a9c95ffad0db5a0dc2a7a262f4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support MDT compaction configs of frequency seconds and trigger strategy [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3677103251

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311",
       "triggerID" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41567fe551118e22bd6a4cf14ffd3fed1dd200ca",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10387",
       "triggerID" : "41567fe551118e22bd6a4cf14ffd3fed1dd200ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * cf6cd8df9259f7e6269be89bbe95680de973d40f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311) 
   * 41567fe551118e22bd6a4cf14ffd3fed1dd200ca Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10387) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658227521

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * afc64bb82327fce36a3b5f9ccb578b11906c0069 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264) 
   * ffdb8f1dc01da66463a4678aeaac4c509e956405 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #17603:
URL: https://github.com/apache/hudi/pull/17603#discussion_r2636643819


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -117,18 +117,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .withDocumentation("Controls how often the metadata table is compacted.");
 
   // Max number of seconds before compaction occurs
-  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
-      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+  public static final ConfigProperty<String> COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.max.delta.seconds")
       .defaultValue(String.valueOf(24 * 60 * 60))
+      .markAdvanced()
+      .sinceVersion("1.1.0")
       .withDocumentation("Number of elapsed seconds after the last compaction, before scheduling a "
       + "new one (for metadata table). "
       + "This config takes effect only for the compaction triggering strategy based on the elapsed time, "
       + "i.e., TIME_ELAPSED, NUM_AND_TIME, and NUM_OR_TIME.");
 
   // Compaction trigger strategy
-  public static final ConfigProperty<String> INLINE_COMPACT_TRIGGER_STRATEGY = ConfigProperty
-      .key(METADATA_PREFIX +  ".compact.inline.trigger.strategy")
+  public static final ConfigProperty<String> COMPACT_TRIGGER_STRATEGY = ConfigProperty
+      .key(METADATA_PREFIX +  ".compact.trigger.strategy")
       .defaultValue("NUM_COMMITS")
+      .markAdvanced()
+      .sinceVersion("1.1.0")

Review Comment:
   Fixed



##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -117,18 +117,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .withDocumentation("Controls how often the metadata table is compacted.");
 
   // Max number of seconds before compaction occurs
-  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
-      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+  public static final ConfigProperty<String> COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.max.delta.seconds")

Review Comment:
   I changed it to 2 hours to be realistic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #17603:
URL: https://github.com/apache/hudi/pull/17603#discussion_r2628886983


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -117,18 +117,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .withDocumentation("Controls how often the metadata table is compacted.");
 
   // Max number of seconds before compaction occurs
-  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
-      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+  public static final ConfigProperty<String> COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.max.delta.seconds")
       .defaultValue(String.valueOf(24 * 60 * 60))
+      .markAdvanced()
+      .sinceVersion("1.1.0")
       .withDocumentation("Number of elapsed seconds after the last compaction, before scheduling a "
       + "new one (for metadata table). "
       + "This config takes effect only for the compaction triggering strategy based on the elapsed time, "
       + "i.e., TIME_ELAPSED, NUM_AND_TIME, and NUM_OR_TIME.");
 
   // Compaction trigger strategy
-  public static final ConfigProperty<String> INLINE_COMPACT_TRIGGER_STRATEGY = ConfigProperty
-      .key(METADATA_PREFIX +  ".compact.inline.trigger.strategy")
+  public static final ConfigProperty<String> COMPACT_TRIGGER_STRATEGY = ConfigProperty
+      .key(METADATA_PREFIX +  ".compact.trigger.strategy")
       .defaultValue("NUM_COMMITS")
+      .markAdvanced()
+      .sinceVersion("1.1.0")

Review Comment:
   Same here



##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -117,18 +117,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .withDocumentation("Controls how often the metadata table is compacted.");
 
   // Max number of seconds before compaction occurs
-  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
-      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+  public static final ConfigProperty<String> COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.max.delta.seconds")
       .defaultValue(String.valueOf(24 * 60 * 60))
+      .markAdvanced()
+      .sinceVersion("1.1.0")

Review Comment:
   Pardon me, actually the since version should be `1.2.0`



##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -117,18 +117,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .withDocumentation("Controls how often the metadata table is compacted.");
 
   // Max number of seconds before compaction occurs
-  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
-      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+  public static final ConfigProperty<String> COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.max.delta.seconds")

Review Comment:
   For MDT, should the default compaction interval seconds be smaller, like 1 hour instead of 24 hours?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support MDT compaction configs of frequency seconds and trigger strategy [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3677267364

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311",
       "triggerID" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41567fe551118e22bd6a4cf14ffd3fed1dd200ca",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10387",
       "triggerID" : "41567fe551118e22bd6a4cf14ffd3fed1dd200ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * 41567fe551118e22bd6a4cf14ffd3fed1dd200ca Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10387) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying INLINE_COMPAC… [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658219662

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * afc64bb82327fce36a3b5f9ccb578b11906c0069 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658668205

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ffdb8f1dc01da66463a4678aeaac4c509e956405 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269) 
   * 3151b1a0ee450c482f6bf0e724cb6e95abdf168a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658360159

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * afc64bb82327fce36a3b5f9ccb578b11906c0069 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264) 
   * ffdb8f1dc01da66463a4678aeaac4c509e956405 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3661694106

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3151b1a0ee450c482f6bf0e724cb6e95abdf168a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276) 
   * 338f1e1c0902035ae94e55693268dbeecfb2151b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3663265572

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 338f1e1c0902035ae94e55693268dbeecfb2151b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292) 
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3662064697

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 338f1e1c0902035ae94e55693268dbeecfb2151b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658452981

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * afc64bb82327fce36a3b5f9ccb578b11906c0069 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264) 
   * ffdb8f1dc01da66463a4678aeaac4c509e956405 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658556102

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ffdb8f1dc01da66463a4678aeaac4c509e956405 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658918261

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3151b1a0ee450c482f6bf0e724cb6e95abdf168a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3658661313

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ffdb8f1dc01da66463a4678aeaac4c509e956405 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269) 
   * 3151b1a0ee450c482f6bf0e724cb6e95abdf168a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #17603:
URL: https://github.com/apache/hudi/pull/17603#discussion_r2624829988


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -116,6 +116,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .sinceVersion("0.7.0")
       .withDocumentation("Controls how often the metadata table is compacted.");
 
+  // Max number of seconds before compaction occurs
+  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")

Review Comment:
   ```suggestion
         .key(METADATA_PREFIX + ".compact.max.delta.seconds")
   ```



##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -116,6 +116,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .sinceVersion("0.7.0")
       .withDocumentation("Controls how often the metadata table is compacted.");
 
+  // Max number of seconds before compaction occurs
+  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")

Review Comment:
   Let's rename the variables and corresponding getters as well.



##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -116,6 +116,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .sinceVersion("0.7.0")
       .withDocumentation("Controls how often the metadata table is compacted.");
 
+  // Max number of seconds before compaction occurs
+  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+      .defaultValue(String.valueOf(24 * 60 * 60))
+      .withDocumentation("Number of elapsed seconds after the last compaction, before scheduling a "
+      + "new one (for metadata table). "
+      + "This config takes effect only for the compaction triggering strategy based on the elapsed time, "
+      + "i.e., TIME_ELAPSED, NUM_AND_TIME, and NUM_OR_TIME.");
+
+  // Compaction trigger strategy
+  public static final ConfigProperty<String> INLINE_COMPACT_TRIGGER_STRATEGY = ConfigProperty
+      .key(METADATA_PREFIX +  ".compact.inline.trigger.strategy")

Review Comment:
   ```suggestion
         .key(METADATA_PREFIX +  ".compact.trigger.strategy")
   ```



##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -116,6 +116,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .sinceVersion("0.7.0")
       .withDocumentation("Controls how often the metadata table is compacted.");
 
+  // Max number of seconds before compaction occurs
+  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+      .defaultValue(String.valueOf(24 * 60 * 60))

Review Comment:
   add `.markAdvanced()` and `.sinceVersion("1.1.0")`



##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -116,6 +116,22 @@ public final class HoodieMetadataConfig extends HoodieConfig {
       .sinceVersion("0.7.0")
       .withDocumentation("Controls how often the metadata table is compacted.");
 
+  // Max number of seconds before compaction occurs
+  public static final ConfigProperty<String> INLINE_COMPACT_TIME_DELTA_SECONDS = ConfigProperty
+      .key(METADATA_PREFIX + ".compact.inline.max.delta.seconds")
+      .defaultValue(String.valueOf(24 * 60 * 60))
+      .withDocumentation("Number of elapsed seconds after the last compaction, before scheduling a "
+      + "new one (for metadata table). "
+      + "This config takes effect only for the compaction triggering strategy based on the elapsed time, "
+      + "i.e., TIME_ELAPSED, NUM_AND_TIME, and NUM_OR_TIME.");
+
+  // Compaction trigger strategy
+  public static final ConfigProperty<String> INLINE_COMPACT_TRIGGER_STRATEGY = ConfigProperty
+      .key(METADATA_PREFIX +  ".compact.inline.trigger.strategy")
+      .defaultValue("NUM_COMMITS")

Review Comment:
   Same on adding `.markAdvanced()` and `.sinceVersion("1.1.0")`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Metadata write config should support specifying compaction seconds and trigger strategy config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17603:
URL: https://github.com/apache/hudi/pull/17603#issuecomment-3663409737

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10264",
       "triggerID" : "afc64bb82327fce36a3b5f9ccb578b11906c0069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10269",
       "triggerID" : "ffdb8f1dc01da66463a4678aeaac4c509e956405",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10276",
       "triggerID" : "3151b1a0ee450c482f6bf0e724cb6e95abdf168a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292",
       "triggerID" : "338f1e1c0902035ae94e55693268dbeecfb2151b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f71c1d037dcec37a3a37e6e85c82b35a5b0151d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308",
       "triggerID" : "5392700def3497a9c95ffad0db5a0dc2a7a262f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311",
       "triggerID" : "cf6cd8df9259f7e6269be89bbe95680de973d40f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 338f1e1c0902035ae94e55693268dbeecfb2151b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10292) 
   * 2f71c1d037dcec37a3a37e6e85c82b35a5b0151d UNKNOWN
   * 5392700def3497a9c95ffad0db5a0dc2a7a262f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10308) 
   * cf6cd8df9259f7e6269be89bbe95680de973d40f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10311) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org