You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/01/03 21:04:50 UTC
[kudu-CR] Consolidate maven-shade-plugin version string in poms
Hello Jean-Daniel Cryans, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5593
to review the following change.
Change subject: Consolidate maven-shade-plugin version string in poms
......................................................................
Consolidate maven-shade-plugin version string in poms
Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
---
M java/kudu-client/pom.xml
M java/kudu-flume-sink/pom.xml
M java/kudu-spark/pom.xml
M java/pom.xml
4 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/5593/1
--
To view, visit http://gerrit.cloudera.org:8080/5593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] Consolidate maven-shade-plugin version string in poms
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Consolidate maven-shade-plugin version string in poms
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5593/1//COMMIT_MSG
Commit Message:
Line 7: Consolidate maven-shade-plugin version string in poms
> Nit: would be nice to also note that this upgrades from 2.3 to 2.4 in two m
Done
--
To view, visit http://gerrit.cloudera.org:8080/5593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Consolidate maven-shade-plugin version string in poms
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5593
to look at the new patch set (#2).
Change subject: Consolidate maven-shade-plugin version string in poms
......................................................................
Consolidate maven-shade-plugin version string in poms
Also bumps the version from 2.3 to 2.4 in kudu-client and
kudu-flume-sink.
Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
---
M java/kudu-client/pom.xml
M java/kudu-flume-sink/pom.xml
M java/kudu-spark/pom.xml
M java/pom.xml
4 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/5593/2
--
To view, visit http://gerrit.cloudera.org:8080/5593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Consolidate maven-shade-plugin version string in poms
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Consolidate maven-shade-plugin version string in poms
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Consolidate maven-shade-plugin version string in poms
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Consolidate maven-shade-plugin version string in poms
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5593/1//COMMIT_MSG
Commit Message:
Line 7: Consolidate maven-shade-plugin version string in poms
Nit: would be nice to also note that this upgrades from 2.3 to 2.4 in two modules.
--
To view, visit http://gerrit.cloudera.org:8080/5593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Consolidate maven-shade-plugin version string in poms
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Consolidate maven-shade-plugin version string in poms
......................................................................
Consolidate maven-shade-plugin version string in poms
Also bumps the version from 2.3 to 2.4 in kudu-client and
kudu-flume-sink.
Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
Reviewed-on: http://gerrit.cloudera.org:8080/5593
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/pom.xml
M java/kudu-flume-sink/pom.xml
M java/kudu-spark/pom.xml
M java/pom.xml
4 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81af2f34a1f0af76bf080c4262149b3798a48ca3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins