You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2014/03/05 00:19:35 UTC
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
GitHub user revans2 opened a pull request:
https://github.com/apache/incubator-storm/pull/42
STORM-252 Upgrade curator to 2.4.0
Currently this pull request also includes the code from STORM-70. But they should go in as part of that JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm new-curator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit a63c0d976aabbb4ff9692ab25aa70aa216a0b0d7
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2014-02-07T22:43:32Z
STORM-70 Upgrade to ZK-3.4.5 and curator-1.3.3
commit 6c82685c274c57576d45ab4d4b05ce03a3d2223b
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2014-02-28T17:15:37Z
Work around ZOOKEEPER-1476 by prefering IPv4 by default.
commit d68cd231a8d365a4ec3b7f873cbbf36d59951630
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2014-03-04T23:10:43Z
STORM-252 Upgrade curator to 2.4.0.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
Posted by ddidier <gi...@git.apache.org>.
Github user ddidier commented on the pull request:
https://github.com/apache/incubator-storm/pull/42#issuecomment-41386571
what's the status on this one ? thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/42#issuecomment-37431804
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/42#issuecomment-41397943
Needs upmerge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/42#issuecomment-41406921
+1, unit tests passed for me in about 2m30s on OSX, and they passed as well in Linux.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/42#issuecomment-41396750
Technically we need another committer's +1 to pull this in. I'll ping someone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/42#issuecomment-41400208
I upmerged, it was a minor conflict in the imports. I also ran all of the unit tests again, and they still pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-252 Upgrade curator to 2.4.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---