You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/05/17 07:07:40 UTC
[GitHub] [helix] huizhilu opened a new pull request #1744: Add cluster pause change listener for controller to resume cluster
huizhilu opened a new pull request #1744:
URL: https://github.com/apache/helix/pull/1744
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1743
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
For cluster pause mode feature: controller needs to listen to the pause signal change and resume the cluster from pause mode upon pause signal change.
This PR does implements following:
- Add ClusterPauseChangeListener in HelixManager
- Implements pause signal data change callback to notify controller
- Selective update cache for pause signal
### Tests
- [ ] The following tests are written for this issue:
- `testClusterPauseSignalUpdate`
- add logic to check pause change notification in `testPauseSignal`
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] huizhilu closed pull request #1744: Add cluster pause change listener for controller to resume cluster
Posted by GitBox <gi...@apache.org>.
huizhilu closed pull request #1744:
URL: https://github.com/apache/helix/pull/1744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1744: Add cluster pause change listener for controller to resume cluster
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1744:
URL: https://github.com/apache/helix/pull/1744#discussion_r633798572
##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -129,13 +129,19 @@
* 4. select the messages that can be sent, needs messages and state model constraints <br>
* 5. send messages
*/
-public class GenericHelixController implements IdealStateChangeListener, LiveInstanceChangeListener,
- MessageListener, CurrentStateChangeListener,
+public class GenericHelixController implements IdealStateChangeListener,
+ LiveInstanceChangeListener,
+ MessageListener,
+ CurrentStateChangeListener,
TaskCurrentStateChangeListener,
CustomizedStateRootChangeListener,
CustomizedStateChangeListener,
- CustomizedStateConfigChangeListener, ControllerChangeListener,
- InstanceConfigChangeListener, ResourceConfigChangeListener, ClusterConfigChangeListener {
+ CustomizedStateConfigChangeListener,
+ ControllerChangeListener,
+ InstanceConfigChangeListener,
+ ResourceConfigChangeListener,
+ ClusterConfigChangeListener,
+ ClusterPauseChangeListener {
Review comment:
This list is becoming super long, can we have a ClusterManagementStatusChangeListener and serve for all the status paths, like Pause, ClusterPause, and Maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] huizhilu commented on a change in pull request #1744: Add cluster pause change listener for controller to resume cluster
Posted by GitBox <gi...@apache.org>.
huizhilu commented on a change in pull request #1744:
URL: https://github.com/apache/helix/pull/1744#discussion_r633833813
##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -129,13 +129,19 @@
* 4. select the messages that can be sent, needs messages and state model constraints <br>
* 5. send messages
*/
-public class GenericHelixController implements IdealStateChangeListener, LiveInstanceChangeListener,
- MessageListener, CurrentStateChangeListener,
+public class GenericHelixController implements IdealStateChangeListener,
+ LiveInstanceChangeListener,
+ MessageListener,
+ CurrentStateChangeListener,
TaskCurrentStateChangeListener,
CustomizedStateRootChangeListener,
CustomizedStateChangeListener,
- CustomizedStateConfigChangeListener, ControllerChangeListener,
- InstanceConfigChangeListener, ResourceConfigChangeListener, ClusterConfigChangeListener {
+ CustomizedStateConfigChangeListener,
+ ControllerChangeListener,
+ InstanceConfigChangeListener,
+ ResourceConfigChangeListener,
+ ClusterConfigChangeListener,
+ ClusterPauseChangeListener {
Review comment:
Only ClusterPause needs a dataChange listener for exiting pause, because controller needs to wait for participants fully exited. The other 2: controller pause and maintenance don't need the data change listener, as they are simply deleted for exiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org