You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/09 05:22:54 UTC

[GitHub] [incubator-inlong] healchow commented on a change in pull request #2415: [INLONG-2414][Manager] Exclude test jar file during the apache-rat-plugin check

healchow commented on a change in pull request #2415:
URL: https://github.com/apache/incubator-inlong/pull/2415#discussion_r802277654



##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/plugin/PluginService.java
##########
@@ -50,7 +50,7 @@
     private List<PluginBinder> pluginBinders;
 
     @Getter
-    private List<Plugin> plugins = new ArrayList<>();
+    private final List<Plugin> plugins = new ArrayList<>();

Review comment:
       Each plugin instance was created by `new`, and not overwrite the `toString` and `equals` methods, so `Set` and `List` are the same in this scenario.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org