[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11097: Register dateTimeConverter,timeConvert,dateTrunc, regexpReplace to v2 functions

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #11097:
URL: https://github.com/apache/pinot/pull/11097#discussion_r1264363993


##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -134,7 +152,14 @@ public enum TransformFunctionType {
   CLPDECODE("clpDecode"),
 
   // Regexp functions
-  REGEXP_EXTRACT("regexpExtract"),
+  REGEXP_EXTRACT("regexpExtract", "regexp_extract"),
+  REGEXPREPLACE("regexpReplace",
+      ReturnTypes.VARCHAR_2000_NULLABLE,

Review Comment:
    there is no `ReturnTypes.VARCHAR`, only `VARCHAR_4`or `VARCHAR_2000`
   <img width="344" alt="image" src="https://github.com/apache/pinot/assets/1202120/afc15901-bcfa-4e1d-9186-9a7363362742">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org