You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2012/03/15 14:22:09 UTC

Review Request: QPID-3899: correct the tracking of acquired messages.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4362/
-----------------------------------------------------------

Review request for qpid and Gordon Sim.


Summary
-------

The current implementation of message groups incorrectly assumed that a message being dequeued had previously been acquired.  In the case of TTL expiration, this is not the case - the expired message is not acquired, it is simply dequeued.

This fix adds a flag that tracks the acquired state of each message in the group.  When a message is dequeued, the total acquired count for the group is decremented ONLY IF the message being dequeued has its acquired flag set.


This addresses bug qpid-3899.
    https://issues.apache.org/jira/browse/qpid-3899


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.h 1300156 
  /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.cpp 1300156 
  /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/msg_groups.py 1300156 

Diff: https://reviews.apache.org/r/4362/diff


Testing
-------

unit tests, + new testcase.


Thanks,

Kenneth