[jira] Commented: (DERBY-2998) Add support for ROW_NUMBER() window function

["Thomas Nielsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544466 ] 

Thomas Nielsen commented on DERBY-2998:
---------------------------------------

My last patch works, it's just not optimized. If someone wants to have a look and comment on it I'm all ears :)

Still investigating why the restriction given in the outer select isn't passed on to the inner select. 
At the moment it seems like the restriction is skipped in ProjectRestrictNode.pushExpressions(). Here, the restriction has become a member in a  PredicateList, on which we call predicateList.pushExpressionsIntoSelect() which checks ColumnRefereces and decides wether to push the predicate or not. It would seem this check somehow fails for the RowNumberColumn.

> Add support for ROW_NUMBER() window function
> --------------------------------------------
>
>                 Key: DERBY-2998
>                 URL: https://issues.apache.org/jira/browse/DERBY-2998
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Thomas Nielsen
>            Assignee: Thomas Nielsen
>            Priority: Minor
>         Attachments: d2998-3.diff, d2998-3.stat, row_number_prototype-2c.diff, row_number_prototype-2c.stat
>
>
> As part of implementing the overall OLAP Operations features of SQL (DERBY-581), implement the ROW_NUMBER() window function.
> More information about this feature is available at http://wiki.apache.org/db-derby/OLAPRowNumber

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.