You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by revans2 <gi...@git.apache.org> on 2017/01/30 16:05:23 UTC
[GitHub] zookeeper pull request #159: ZOOKEEPER-2678: Discovery and Sync can take a v...
GitHub user revans2 opened a pull request:
https://github.com/apache/zookeeper/pull/159
ZOOKEEPER-2678: Discovery and Sync can take a very long time on large DBs
This is the master version of #157
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/zookeeper ZOOKEEPER-2678-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #159: ZOOKEEPER-2678: Discovery and Sync can take a very lon...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/159
This also applies cleanly to the 3.5 line #157 is for the 3.4 line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #159: ZOOKEEPER-2678: Discovery and Sync can take a very lon...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/159
@hanm thanks for the reviews I removed the incorrect comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #159: ZOOKEEPER-2678: Discovery and Sync can take a v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #159: ZOOKEEPER-2678: Discovery and Sync can take a v...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/159#discussion_r100552192
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -498,14 +504,19 @@ else if (qp.getType() == Leader.SNAP) {
throw new Exception("changes proposed in reconfig");
}
}
- if (!snapshotTaken) { // true for the pre v1.0 case
- zk.takeSnapshot();
+ if (isPreZAB1_0) {
+ zk.takeSnapshot();
self.setCurrentEpoch(newEpoch);
}
self.setZooKeeperServer(zk);
self.adminServer.setZooKeeperServer(zk);
break outerLoop;
- case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
+ case Leader.NEWLEADER: // Getting NEWLEADER here instead of in discovery
+ // means this is Zab 1.0
+ // Create updatingEpoch file and remove it after current
--- End diff --
You are right will fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #159: ZOOKEEPER-2678: Discovery and Sync can take a v...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/159#discussion_r100389617
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -498,14 +504,19 @@ else if (qp.getType() == Leader.SNAP) {
throw new Exception("changes proposed in reconfig");
}
}
- if (!snapshotTaken) { // true for the pre v1.0 case
- zk.takeSnapshot();
+ if (isPreZAB1_0) {
+ zk.takeSnapshot();
self.setCurrentEpoch(newEpoch);
}
self.setZooKeeperServer(zk);
self.adminServer.setZooKeeperServer(zk);
break outerLoop;
- case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
+ case Leader.NEWLEADER: // Getting NEWLEADER here instead of in discovery
+ // means this is Zab 1.0
+ // Create updatingEpoch file and remove it after current
--- End diff --
This comment does not apply here - my guess is it is a copy paste error from your branch-3.4 patch... can we get this comment removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---