You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by salbahra <gi...@git.apache.org> on 2015/06/13 08:42:38 UTC
[GitHub] cordova-plugin-geolocation pull request: Allow Android devices wit...
GitHub user salbahra opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/43
Allow Android devices without GPS to still install
Apps with this plugin being used will not be install the Android app from the Google Play store due to permission restrictions. Setting android:required to false will still add this permission to the project but not preclude the app from being installed on a device without GPS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/salbahra/cordova-plugin-geolocation patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 8acb6cb8187ce44edfb91bf1dfebcfa7ce1cf383
Author: Samer Albahra <sa...@gmail.com>
Date: 2015-06-13T06:42:23Z
Allow Android devices without GPS to still install
Apps with this plugin being used will not be install the Android app from the Google Play store due to permission restrictions. Setting android:required to false will still add this permission to the project but not preclude the app from being installed on a device without GPS.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation issue #43: Allow Android devices without GPS to s...
Posted by mahmoudkhalafallah <gi...@git.apache.org>.
Github user mahmoudkhalafallah commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/43
@stevengill
i got this email from google,
====
Hello Google Play Developer,
We're writing to let you know that the apps listed at the end of this email may be affected by an upcoming platform change.
**Action required**: If your app requires GPS hardware to operate properly, you will need to explicitly add the "android.hardware.location.gps" uses-feature to your manifest.
**What\u2019s changing**
We\u2019re making a change on October 15th, 2016 that will affect apps targeting API version 21 (Android 5.0, Lollipop) or higher that use ACCESS_FINE_LOCATION but don't explicitly have the "android.hardware.location.gps" uses-feature. Going forward, these apps will be available to install on devices that don't have GPS hardware. In most cases this won't be an issue since Wi-Fi and Cell-ID based location provides high enough fidelity for the typical operation of these apps. However, any apps that require GPS hardware, such as GPS navigators, should explicitly add the "android.hardware.location.gps" uses-feature to their manifest.
If your app requires GPS to function properly and you do not include android.hardware.location.gps in your manifest declaration, your users may have a poor app experience.
Also, if you\u2019re using the fused location provider and wish to receive the most accurate location samples from GPS (i.e. with PRIORITY_HIGH_ACCURACY), you must include the "android.hardware.location.gps" feature in your app\u2019s manifest to ensure that Google Play only distributes your app to devices with GPS sensors.
You can read more about this change in the Android Developers Help Center.
Regards,
The Google Play Team
====
So are you going to fix this issue before October 15th, 2016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation issue #43: Allow Android devices without GPS to s...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/43
@mahmoudkhalafallah we are working on adding the permission to the plugin + release it before Oct 15th.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Allow Android devices wit...
Posted by salbahra <gi...@git.apache.org>.
Github user salbahra commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/43#issuecomment-111682938
Actually, this should be on uses-feature not uses-permission. You can disregard this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Allow Android devices wit...
Posted by salbahra <gi...@git.apache.org>.
Github user salbahra closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org