[GitHub] [rocketmq-ons] ShannonDing commented on a change in pull request #12: [ISSUE #13]Add OpenMessaging API support

[GitBox <gi...@apache.org>]

ShannonDing commented on a change in pull request #12: [ISSUE #13]Add OpenMessaging API support
URL: https://github.com/apache/rocketmq-ons/pull/12#discussion_r321135743
 
 

 ##########
 File path: ons-core/ons-client/src/main/java/io/openmessaging/rocketmq/MessagingAccessPointImpl.java
 ##########
 @@ -15,38 +15,58 @@
  * limitations under the License.
  */
 
-package org.apache.rocketmq.ons.api.impl;
+package io.openmessaging.rocketmq;
 
+import io.openmessaging.Constants;
+import io.openmessaging.Consumer;
+import io.openmessaging.Message;
+import io.openmessaging.MessagingAccessPoint;
+import io.openmessaging.Producer;
+import io.openmessaging.PullConsumer;
+import io.openmessaging.batch.BatchConsumer;
+import io.openmessaging.order.OrderConsumer;
+import io.openmessaging.order.OrderProducer;
+import io.openmessaging.transaction.LocalTransactionChecker;
+import io.openmessaging.transaction.TransactionProducer;
+import io.openmessaging.transaction.TransactionStatus;
+import java.util.Properties;
 import org.apache.rocketmq.client.producer.LocalTransactionState;
 import org.apache.rocketmq.client.producer.TransactionCheckListener;
 import org.apache.rocketmq.common.message.MessageExt;
-import java.util.Properties;
-import org.apache.rocketmq.ons.api.Constants;
-import org.apache.rocketmq.ons.api.Consumer;
-import org.apache.rocketmq.ons.api.Message;
-import org.apache.rocketmq.ons.api.ONSFactoryAPI;
-import org.apache.rocketmq.ons.api.Producer;
-import org.apache.rocketmq.ons.api.batch.BatchConsumer;
 import org.apache.rocketmq.ons.api.impl.rocketmq.BatchConsumerImpl;
 import org.apache.rocketmq.ons.api.impl.rocketmq.ConsumerImpl;
 import org.apache.rocketmq.ons.api.impl.rocketmq.ONSUtil;
 import org.apache.rocketmq.ons.api.impl.rocketmq.OrderConsumerImpl;
 import org.apache.rocketmq.ons.api.impl.rocketmq.OrderProducerImpl;
 import org.apache.rocketmq.ons.api.impl.rocketmq.ProducerImpl;
 import org.apache.rocketmq.ons.api.impl.rocketmq.TransactionProducerImpl;
-import org.apache.rocketmq.ons.api.order.OrderConsumer;
-import org.apache.rocketmq.ons.api.order.OrderProducer;
-import org.apache.rocketmq.ons.api.transaction.LocalTransactionChecker;
-import org.apache.rocketmq.ons.api.transaction.TransactionProducer;
-import org.apache.rocketmq.ons.api.transaction.TransactionStatus;
 
-public class ONSFactoryImpl implements ONSFactoryAPI {
+public class MessagingAccessPointImpl implements MessagingAccessPoint {
+
+    private Properties attributes;
+
+    public MessagingAccessPointImpl(Properties attributes) {
+        this.attributes = attributes;
+    }
+
+    @Override
+    public String version() {
+        return "1.1.3";
 
 Review comment:
   what is the mean of this version "1.1.3"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services