You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by km...@apache.org on 2008/01/21 04:28:43 UTC

svn commit: r613742 - /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/XMLEncoderTest.java

Author: kmenard
Date: Sun Jan 20 19:28:42 2008
New Revision: 613742

URL: http://svn.apache.org/viewvc?rev=613742&view=rev
Log:
No need to call toString() on a String.

Modified:
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/XMLEncoderTest.java

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/XMLEncoderTest.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/XMLEncoderTest.java?rev=613742&r1=613741&r2=613742&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/XMLEncoderTest.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/xml/XMLEncoderTest.java Sun Jan 20 19:28:42 2008
@@ -67,7 +67,7 @@
 
         String comp = loadTestFileAsString("encoded-simple-collection.xml");
 
-        assertEquals(comp.toString(), result);
+        assertEquals(comp, result);
     }
 
     private String loadTestFileAsString(String filename) throws IOException {
@@ -104,10 +104,10 @@
         // there are differences in attribute order encoding, so there can be more than
         // one valid output depending on the parser used...
 
-        if (!comp.toString().equals(result)) {
+        if (!comp.equals(result)) {
             comp = loadTestFileAsString("encoded-complex-collection-alt1.xml");
         }
-        assertEquals(comp.toString(), result);
+        assertEquals(comp, result);
     }
 
     public void testSimpleMapping() throws Exception {
@@ -122,7 +122,7 @@
 
         String comp = loadTestFileAsString("simple-mapped.xml");
         
-        assertEquals(comp.toString(), result);
+        assertEquals(comp, result);
     }
     
     //  Added test for 1-to-1 relationship mappings, per CAY-597.
@@ -151,7 +151,7 @@
 
         String comp = loadTestFileAsString("1to1-mapped.xml");
         
-        assertEquals(comp.toString(), result);
+        assertEquals(comp, result);
     }
     
     // Added test for 1-to-1 relationships, per CAY-597.
@@ -177,7 +177,7 @@
 
         String comp = loadTestFileAsString("1to1-encoded.xml");
         
-        assertEquals(comp.toString(), xml);
+        assertEquals(comp, xml);
     }
 
     public void testCollectionMapping() throws Exception {
@@ -196,7 +196,7 @@
 
         String comp = loadTestFileAsString("collection-mapped.xml");
 
-        assertEquals(comp.toString(), result);
+        assertEquals(comp, result);
     }
 
     public void testEncodeDataObjectsList() throws Exception {
@@ -210,7 +210,7 @@
 
         String comp = loadTestFileAsString("data-objects-encoded.xml");
         
-        assertEquals(comp.toString(), xml);
+        assertEquals(comp, xml);
     }
 
     public void testDataObjectsListMapping() throws Exception {
@@ -227,6 +227,6 @@
 
         String comp = loadTestFileAsString("data-objects-mapped.xml");
 
-        assertEquals(comp.toString(), xml);
+        assertEquals(comp, xml);
     }
 }