You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tim Ellison (JIRA)" <ji...@apache.org> on 2006/03/15 13:42:43 UTC
[jira] Resolved: (HARMONY-161) Improper override method in
java/util/zip/GZIPOutputStream.close()
[ http://issues.apache.org/jira/browse/HARMONY-161?page=all ]
Tim Ellison resolved HARMONY-161:
---------------------------------
Resolution: Fixed
Paulex,
Applied patch to ARCHIVE module java.util.zip.GZIPOutputStream at repo revision 386064.
Please check that it was applied as you expected.
> Improper override method in java/util/zip/GZIPOutputStream.close()
> ------------------------------------------------------------------
>
> Key: HARMONY-161
> URL: http://issues.apache.org/jira/browse/HARMONY-161
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Tim Ellison
> Attachments: java.util.zip.GZIPOutputStream.patch
>
> java/util/zip/DeflaterOutputStream.close() is overriden by java/util/zip/GZIPOutputStream in Harmony while it isn't in spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Resolved: (HARMONY-161) Improper override method in java/util/zip/GZIPOutputStream.close()
Posted by Paulex Yang <pa...@gmail.com>.
Tim
that's fine, thank you.
Tim Ellison wrote:
> Paulex,
>
> As we recently discussed, there is nothing in the spec that prevents us
> from (re-)implementing the method in the subclass, even though it is not
> specified to have any additional behavior to the inherited version. So
> while the point of the issue may be wrong, I've applied the patch to
> remove the close() method as I see it is not required.
>
> Regards,
> Tim
>
> Tim Ellison (JIRA) wrote:
>
>> [ http://issues.apache.org/jira/browse/HARMONY-161?page=all ]
>>
>> Tim Ellison resolved HARMONY-161:
>> ---------------------------------
>>
>> Resolution: Fixed
>>
>> Paulex,
>>
>> Applied patch to ARCHIVE module java.util.zip.GZIPOutputStream at repo revision 386064.
>>
>> Please check that it was applied as you expected.
>>
>>
>>
>>> Improper override method in java/util/zip/GZIPOutputStream.close()
>>> ------------------------------------------------------------------
>>>
>>> Key: HARMONY-161
>>> URL: http://issues.apache.org/jira/browse/HARMONY-161
>>> Project: Harmony
>>> Type: Bug
>>> Components: Classlib
>>> Reporter: Paulex Yang
>>> Assignee: Tim Ellison
>>> Attachments: java.util.zip.GZIPOutputStream.patch
>>>
>>> java/util/zip/DeflaterOutputStream.close() is overriden by java/util/zip/GZIPOutputStream in Harmony while it isn't in spec.
>>>
>
>
--
Paulex Yang
China Software Development Lab
IBM
Re: [jira] Resolved: (HARMONY-161) Improper override method in java/util/zip/GZIPOutputStream.close()
Posted by Tim Ellison <t....@gmail.com>.
Paulex,
As we recently discussed, there is nothing in the spec that prevents us
from (re-)implementing the method in the subclass, even though it is not
specified to have any additional behavior to the inherited version. So
while the point of the issue may be wrong, I've applied the patch to
remove the close() method as I see it is not required.
Regards,
Tim
Tim Ellison (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-161?page=all ]
>
> Tim Ellison resolved HARMONY-161:
> ---------------------------------
>
> Resolution: Fixed
>
> Paulex,
>
> Applied patch to ARCHIVE module java.util.zip.GZIPOutputStream at repo revision 386064.
>
> Please check that it was applied as you expected.
>
>
>> Improper override method in java/util/zip/GZIPOutputStream.close()
>> ------------------------------------------------------------------
>>
>> Key: HARMONY-161
>> URL: http://issues.apache.org/jira/browse/HARMONY-161
>> Project: Harmony
>> Type: Bug
>> Components: Classlib
>> Reporter: Paulex Yang
>> Assignee: Tim Ellison
>> Attachments: java.util.zip.GZIPOutputStream.patch
>>
>> java/util/zip/DeflaterOutputStream.close() is overriden by java/util/zip/GZIPOutputStream in Harmony while it isn't in spec.
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.