You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Guillaume Smet (JIRA)" <ji...@apache.org> on 2011/01/09 11:33:45 UTC
[jira] Created: (WICKET-3315) PackagedTextTemplate should set
lastModifiedTime
PackagedTextTemplate should set lastModifiedTime
------------------------------------------------
Key: WICKET-3315
URL: https://issues.apache.org/jira/browse/WICKET-3315
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.15
Reporter: Guillaume Smet
Priority: Minor
Hi,
When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
Any comment?
--
Guillaume
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3315) PackagedTextTemplate should set
lastModifiedTime
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl resolved WICKET-3315.
--------------------------------
Resolution: Fixed
fixed in trunk
> PackagedTextTemplate should set lastModifiedTime
> ------------------------------------------------
>
> Key: WICKET-3315
> URL: https://issues.apache.org/jira/browse/WICKET-3315
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Guillaume Smet
> Assignee: Peter Ertl
> Priority: Minor
> Attachments: WICKET-3315.patch
>
>
> Hi,
> When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
> IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
> AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
> Any comment?
> --
> Guillaume
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3315) PackagedTextTemplate should set
lastModifiedTime
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980460#action_12980460 ]
Hudson commented on WICKET-3315:
--------------------------------
Integrated in Apache Wicket 1.4.x #383 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/383/])
> PackagedTextTemplate should set lastModifiedTime
> ------------------------------------------------
>
> Key: WICKET-3315
> URL: https://issues.apache.org/jira/browse/WICKET-3315
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Guillaume Smet
> Assignee: Peter Ertl
> Priority: Minor
> Fix For: 1.4.16, 1.5-M4
>
> Attachments: WICKET-3315.patch
>
>
> Hi,
> When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
> IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
> AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
> Any comment?
> --
> Guillaume
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3315) PackagedTextTemplate should set
lastModifiedTime
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-3315:
-------------------------------
Fix Version/s: 1.4.16
> PackagedTextTemplate should set lastModifiedTime
> ------------------------------------------------
>
> Key: WICKET-3315
> URL: https://issues.apache.org/jira/browse/WICKET-3315
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Guillaume Smet
> Assignee: Peter Ertl
> Priority: Minor
> Fix For: 1.4.16
>
> Attachments: WICKET-3315.patch
>
>
> Hi,
> When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
> IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
> AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
> Any comment?
> --
> Guillaume
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3315) PackagedTextTemplate should set
lastModifiedTime
Posted by "Guillaume Smet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Smet updated WICKET-3315:
-----------------------------------
Attachment: WICKET-3315.patch
> PackagedTextTemplate should set lastModifiedTime
> ------------------------------------------------
>
> Key: WICKET-3315
> URL: https://issues.apache.org/jira/browse/WICKET-3315
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Guillaume Smet
> Priority: Minor
> Attachments: WICKET-3315.patch
>
>
> Hi,
> When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
> IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
> AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
> Any comment?
> --
> Guillaume
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3315) PackagedTextTemplate should set
lastModifiedTime
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-3315:
-------------------------------------
Assignee: Peter Ertl
> PackagedTextTemplate should set lastModifiedTime
> ------------------------------------------------
>
> Key: WICKET-3315
> URL: https://issues.apache.org/jira/browse/WICKET-3315
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Guillaume Smet
> Assignee: Peter Ertl
> Priority: Minor
> Attachments: WICKET-3315.patch
>
>
> Hi,
> When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
> IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
> AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
> Any comment?
> --
> Guillaume
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3315) PackagedTextTemplate should set
lastModifiedTime
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-3315:
-------------------------------
Fix Version/s: 1.5-M4
> PackagedTextTemplate should set lastModifiedTime
> ------------------------------------------------
>
> Key: WICKET-3315
> URL: https://issues.apache.org/jira/browse/WICKET-3315
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Guillaume Smet
> Assignee: Peter Ertl
> Priority: Minor
> Fix For: 1.4.16, 1.5-M4
>
> Attachments: WICKET-3315.patch
>
>
> Hi,
> When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
> IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
> AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
> Any comment?
> --
> Guillaume
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.