You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/10 04:02:52 UTC
[PR] fix: validate all Lite subscription topics [rocketmq]
Aias00 opened a new pull request, #10897:
URL: https://github.com/apache/rocketmq/pull/10897
## Summary
- validate every Lite subscription against the group's configured bound topic
- reject a subscription set when any entry targets a different topic
Closes #10895
## Tests
- JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home PATH="/Library/Java/JavaVirtualMachines/jdk-17.0.3+7/Contents/Home/bin:/Users/aias/.qoder/entry:/Users/aias/.nvm/versions/node/v22.23.1/bin:/Applications/Visual Studio Code.app/Contents/Resources/app/bin:/Library/Java/JavaVirtualMachines/jdk-17.0.3+7/Contents/Home/bin:/Users/aias/.local/share/hyperframes-python/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pmk/env/global/bin:/Library/Apple/usr/bin:/Applications/Wireshark.app/Contents/MacOS:/usr/local/go/bin:/Users/aias/.nvm/versions/node/v22.23.1/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/Users/aias/.
codex/tmp/arg0/codex-arg0R70T9O:/Users/aias/.grok/bin:/Users/aias/.opencode/bin:/Users/aias/.antigravity/antigravity/bin:/Users/aias/.local/bin:/Users/aias/.bun/bin:/Users/aias/.local/share/hyperframes-python/bin:/Users/aias/.yarn/bin:/Users/aias/.config/yarn/global/node_modules/.bin:/Users/aias/.nvm/versions/node/v22.23.1/bin:/Applications/Visual Studio Code.app/Contents/Resources/app/bin:/Library/Java/JavaVirtualMachines/jdk-17.0.3+7/Contents/Home/bin:/Users/aias/.cargo/bin:/Applications/iTerm.app/Contents/Resources/utilities:.:/Users/aias/Work/apache-jmeter-5.5/bin:/Users/aias/Work/arthas:/Users/aias/Library/Python/3.8/bin:/Users/aias/Library/Application Support/JetBrains/Toolbox/scripts:/Applications/IntelliJ IDEA.app/Contents/MacOS:/Users/aias/.orbstack/bin:/Users/aias/.maestro/bin:.:/Users/aias/Work/apache-jmeter-5.5/bin:/Users/aias/.local/share/hyperframes-python/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbi
n:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pmk/env/global/bin:/Library/Apple/usr/bin:/Applications/Wireshark.app/Contents/MacOS:/usr/local/go/bin:/Users/aias/.nvm/versions/node/v22.23.1/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/Users/aias/.codex/tmp/arg0/codex-arg0R70T9O:/Users/aias/.grok/bin:/Users/aias/.opencode/bin:/Users/aias/.antigravity/antigravity/bin:/Users/aias/.local/bin:/Users/aias/.bun/bin:/Users/aias/.local/share/hyperframes-python/bin:/Users/aias/.yarn/bin:/Users/aias/.config/yarn/global/node_modules/.bin:/Users/aias/.nvm/versions/node/v22.23.1/bin:/Applications/Visual Studio Code.app/Contents/Resources/app/bin:/Library/Java/JavaVirtualMachines/jdk-17.0.3+7/Contents/Home/bin:/Users/aias/.cargo/bin:/Applications/iTerm
.app/Contents/Resources/utilities:.:/Users/aias/Work/apache-jmeter-5.5/bin:/Users/aias/Work/arthas:/Users/aias/Library/Python/3.8/bin:/Users/aias/Library/Application Support/JetBrains/Toolbox/scripts:/Applications/IntelliJ IDEA.app/Contents/MacOS:/Users/aias/.orbstack/bin:/Users/aias/.maestro/bin:/Users/aias/Work/arthas:/Users/aias/Library/Python/3.8/bin:/Users/aias/Library/Application Support/JetBrains/Toolbox/scripts:/Applications/IntelliJ IDEA.app/Contents/MacOS:/Users/aias/.orbstack/bin:/Users/aias/.local/bin" mvn -pl proxy -Dtest=ClientProcessorTest test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: validate all Lite subscription topics [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10897:
URL: https://github.com/apache/rocketmq/pull/10897#issuecomment-5235897827
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.30%. Comparing base ([`e345861`](https://app.codecov.io/gh/apache/rocketmq/commit/e3458616d207ee636b1762f0f8dcf788a590d59d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`24215e2`](https://app.codecov.io/gh/apache/rocketmq/commit/24215e21a3e64c0f45eb89edfeca98e439cf0131?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10897 +/- ##
=============================================
- Coverage 48.41% 48.30% -0.12%
+ Complexity 13571 13531 -40
=============================================
Files 1380 1380
Lines 101165 101167 +2
Branches 13127 13128 +1
=============================================
- Hits 48981 48866 -115
- Misses 46220 46305 +85
- Partials 5964 5996 +32
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10897?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org